Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 )
Change subject: [WIP] mainboard: Add Acer ES1-572 ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/... File src/mainboard/acer/es1-572/romstage.c:
https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/... PS4, Line 47: mainboard_fill_rcomp_res_data same as above
https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/... PS4, Line 54: mainboard_fill_rcomp_strength_data same
https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/... PS4, Line 74: d_fill_dq_map_data(&mem_cfg->DqByteMapCh0, &mem_cfg->DqByteMapCh1); : mainboard_fill_dqs_map_data(&mem_cfg->DqsMapCpu2DramCh0, &mem_cfg->DqsMapCpu2DramCh1); : mainboard_fill_rcomp_res_data(&mem_cfg->RcompResistor); : mainboard_fill_rcomp_strength_data(&mem_cfg->Rcomp same
-
Michael Niewöhner (Code Review)