Change in coreboot[master]: mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10
John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47691 )
Change subject: mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10 ......................................................................
mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10
Increase TCC offset value from 5 to 10 for Thermal Control Circuit (TCC) activation.
BUG=b:171531244 TEST=build and verify by thermal team
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Ic2822b059f166779e1f0bcf92e753dad1078783c --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/47691/1
diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb index 1be1012..1bf90e7 100644 --- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb @@ -59,7 +59,7 @@ .tdp_pl2_override = 20, }"
- register "tcc_offset" = "5" # TCC of 95C + register "tcc_offset" = "10" # TCC of 90C
device domain 0 on device pci 04.0 on
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47691 )
Change subject: mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10 ......................................................................
Patch Set 1: Code-Review+1
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47691 )
Change subject: mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10 ......................................................................
Patch Set 1:
This change is ready for review.
Ben Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47691 )
Change subject: mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47691/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47691/1/src/mainboard/google/dedede... PS1, Line 62: 90C JSL Tjmax is 105C, so it should be "TCC of 95C", right?
Hello build bot (Jenkins), Henry Sun, Sumeet R Pawnikar, Marco Chen, Karthik Ramasubramanian, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47691
to look at the new patch set (#2).
Change subject: mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10 ......................................................................
mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10
Increase TCC offset value from 5 to 10 for Thermal Control Circuit (TCC) activation.
BUG=b:171531244 TEST=build and verify by thermal team
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Ic2822b059f166779e1f0bcf92e753dad1078783c --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/47691/2
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47691 )
Change subject: mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47691/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47691/1/src/mainboard/google/dedede... PS1, Line 62: 90C
JSL Tjmax is 105C, so it should be "TCC of 95C", right?
Done
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47691 )
Change subject: mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10 ......................................................................
Patch Set 2: Code-Review+2
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47691 )
Change subject: mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10 ......................................................................
Patch Set 2: Code-Review+1
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47691 )
Change subject: mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10 ......................................................................
Patch Set 2: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47691 )
Change subject: mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10 ......................................................................
Patch Set 2: Code-Review+2
Ben Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47691 )
Change subject: mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10 ......................................................................
Patch Set 2: Code-Review+1
Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47691 )
Change subject: mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10 ......................................................................
mb/google/dedede/variants/madoo: Increase TCC offset from 5 to 10
Increase TCC offset value from 5 to 10 for Thermal Control Circuit (TCC) activation.
BUG=b:171531244 TEST=build and verify by thermal team
Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Ic2822b059f166779e1f0bcf92e753dad1078783c Reviewed-on: https://review.coreboot.org/c/coreboot/+/47691 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Ben Kao ben.kao@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Sumeet R Pawnikar: Looks good to me, approved John Su: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved EricR Lai: Looks good to me, approved Ben Kao: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb index 1be1012..c7f3995 100644 --- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb @@ -59,7 +59,7 @@ .tdp_pl2_override = 20, }"
- register "tcc_offset" = "5" # TCC of 95C + register "tcc_offset" = "10" # TCC of 95C
device domain 0 on device pci 04.0 on
-
Ben Kao (Code Review) -
EricR Lai (Code Review)
-
John Su (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Sumeet R Pawnikar (Code Review)