Change in coreboot[master]: arch/x86: Refactor the SMBIOS type 17 write function - coreboot-gerrit

25 Oct 2021


      Attention is currently required from: Jason Glenesk, Jakub Czapiga, Marshall Dawson, Tim Wawrzynczak, Angel Pons, Rob Barnes, Patrick Rudolph, Felix Held.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56628 )
Change subject: arch/x86: Refactor the SMBIOS type 17 write function
......................................................................
Patch Set 15:
(2 comments)
File src/device/dram/spd.c:
https://review.coreboot.org/c/coreboot/+/56628/comment/e72a47e2_69579420 
PS15, Line 3: #include <console/console.h>
...
is this required?
Ack
https://review.coreboot.org/c/coreboot/+/56628/comment/713ed8da_0ac6d777 
PS15, Line 6: #include <stdlib.h>
...
is this required?
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56628
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia337ac8f50b61ae78d86a07c7a86aa9c248bad50
Gerrit-Change-Number: 56628
Gerrit-PatchSet: 15
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 25 Oct 2021 08:43:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment