Change in coreboot[master]: mb/amd/mandolin: select ACPI driver for internal memory mapped UARTs
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44529 )
Change subject: mb/amd/mandolin: select ACPI driver for internal memory mapped UARTs ......................................................................
mb/amd/mandolin: select ACPI driver for internal memory mapped UARTs
In order for Linux to find and use the SoC's integrated UARTs, they need to be exposed in ACPI.
BUG=b:165020060 TEST=Linux detects the SoC's integrated UARTs.
Change-Id: Iaa66657b88f62b2067c865c3e1945b7bdbf9be23 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/44529/1
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index 0360e95..1d2fa5e 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -10,6 +10,7 @@ select BOARD_ROMSIZE_KB_8192 if BOARD_AMD_MANDOLIN select AZALIA_PLUGIN_SUPPORT select HAVE_ACPI_RESUME + select DRIVERS_UART_ACPI select PICASSO_CONSOLE_UART if !AMD_LPC_DEBUG_CARD
config FMDFILE
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44529 )
Change subject: mb/amd/mandolin: select ACPI driver for internal memory mapped UARTs ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44529 )
Change subject: mb/amd/mandolin: select ACPI driver for internal memory mapped UARTs ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44529 )
Change subject: mb/amd/mandolin: select ACPI driver for internal memory mapped UARTs ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/Kconfig:
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/... PS1, Line 13: DRIVERS_UART_ACPI if !AMD_LPC_DEBUG_CARD
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/... PS1, Line 14: PICASSO_CONSOLE_UART Can Picasso's UARTs work in non-ACPI mode? If not, I'd select DRIVERS_UART_ACPI in PICASSO_CONSOLE_UART
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44529 )
Change subject: mb/amd/mandolin: select ACPI driver for internal memory mapped UARTs ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/Kconfig:
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/... PS1, Line 13: DRIVERS_UART_ACPI
if !AMD_LPC_DEBUG_CARD
no, that's independent of that setting. AMD_LPC_DEBUG_CARD only says that the LPC UART expansion board is present and should be used for coreboot console. The ACPI UART driver makes it possible for the OS to find and use the MMIO UARTs that aren't disabled in devicetree. Even when using the LPC UART, it still might be useful to still be able to use the integrated UARTs from the OS.
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/... PS1, Line 14: PICASSO_CONSOLE_UART
Can Picasso's UARTs work in non-ACPI mode? If not, I'd select DRIVERS_UART_ACPI in PICASSO_CONSOLE_U […]
One of the UARTs can be switched to legacy mode; see CB:40322 If the UARTs are in MMIO mode, there needs to be some entry in the ACPI tables in order for the operating system to find and use it. PICASSO_CONSOLE_UART is independent of UART ACPI mode; the former only affects coreboot and the latter only the OS. PICASSO_CONSOLE_UART doesn't enable the integrated UARTs, but only makes coreboot console use them.
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44529 )
Change subject: mb/amd/mandolin: select ACPI driver for internal memory mapped UARTs ......................................................................
mb/amd/mandolin: select ACPI driver for internal memory mapped UARTs
In order for Linux to find and use the SoC's integrated UARTs, they need to be exposed in ACPI.
BUG=b:165020060 TEST=Linux detects the SoC's integrated UARTs.
Change-Id: Iaa66657b88f62b2067c865c3e1945b7bdbf9be23 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/44529 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index 0360e95..1d2fa5e 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -10,6 +10,7 @@ select BOARD_ROMSIZE_KB_8192 if BOARD_AMD_MANDOLIN select AZALIA_PLUGIN_SUPPORT select HAVE_ACPI_RESUME + select DRIVERS_UART_ACPI select PICASSO_CONSOLE_UART if !AMD_LPC_DEBUG_CARD
config FMDFILE
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44529 )
Change subject: mb/amd/mandolin: select ACPI driver for internal memory mapped UARTs ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/Kconfig:
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/... PS1, Line 13: DRIVERS_UART_ACPI
no, that's independent of that setting. […]
Ack
https://review.coreboot.org/c/coreboot/+/44529/1/src/mainboard/amd/mandolin/... PS1, Line 14: PICASSO_CONSOLE_UART
One of the UARTs can be switched to legacy mode; see CB:40322 […]
Ack
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Raul Rangel (Code Review)