HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31554
Change subject: gizmosphere/gizmo2:(faile test) ......................................................................
gizmosphere/gizmo2:(faile test)
why gizmo2 failed when using IASL v 20190215? https://qa.coreboot.org/job/coreboot-toolchain/532/testReport/(root)/board/G...
Change-Id: I1e4ca2c765083db3a27e415d3a69bef0912a606b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/gizmosphere/gizmo2/acpi/superio.asl 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/31554/1
diff --git a/src/mainboard/gizmosphere/gizmo2/acpi/superio.asl b/src/mainboard/gizmosphere/gizmo2/acpi/superio.asl index e69de29..0043c3b 100644 --- a/src/mainboard/gizmosphere/gizmo2/acpi/superio.asl +++ b/src/mainboard/gizmosphere/gizmo2/acpi/superio.asl @@ -0,0 +1 @@ +/* test */
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31554 )
Change subject: gizmosphere/gizmo2:(faile test) ......................................................................
Patch Set 1:
The problematic code is in `AmdImc.asl`, however it's the place where it is included (`fch.asl`) that puts everything in a Method scope. I assume, moving the #include above the _INI Method in `fch.asl` would fix it.
Hello Kyösti Mälkki, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31554
to look at the new patch set (#2).
Change subject: gizmosphere/gizmo2:(faile test) ......................................................................
gizmosphere/gizmo2:(faile test)
will gizmo2 faile when using IASL v 20190215? https://qa.coreboot.org/job/coreboot-toolchain/532/testReport/(root)/board/G...
Change-Id: I1e4ca2c765083db3a27e415d3a69bef0912a606b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/acpi/fch.asl M src/southbridge/amd/pi/hudson/acpi/fch.asl 2 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/31554/2
Hello Kyösti Mälkki, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31554
to look at the new patch set (#3).
Change subject: sb/amd/{agesa,pi}/hudson/acpi/fch.asl: Fix 'Object cannot be accessed' ......................................................................
sb/amd/{agesa,pi}/hudson/acpi/fch.asl: Fix 'Object cannot be accessed'
Error spotted using IASL 20190215 on mainboard GIZMOSPHERE_GIZMO2: "Object is created temporarily in another method and cannot be accessed"
Change-Id: I1e4ca2c765083db3a27e415d3a69bef0912a606b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/acpi/fch.asl M src/southbridge/amd/pi/hudson/acpi/fch.asl 2 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/31554/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31554 )
Change subject: sb/amd/{agesa,pi}/hudson/acpi/fch.asl: Fix 'Object cannot be accessed' ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/31554/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31554/3//COMMIT_MSG@7 PS3, Line 7: sb/amd/{agesa,pi}/hudson/acpi/fch.asl: Fix 'Object cannot be accessed' This is too long and if anybody would care about the full path, he can look it up. This prefix would be enough:
sb/amd/hudson/acpi:
Also, you are not "fixing" an error message, you are fixing code...
https://review.coreboot.org/#/c/31554/3/src/southbridge/amd/agesa/hudson/acp... File src/southbridge/amd/agesa/hudson/acpi/fch.asl:
https://review.coreboot.org/#/c/31554/3/src/southbridge/amd/agesa/hudson/acp... PS3, Line 178: // #include "acpi/AmdImc.asl" /* Hudson IMC function */ Please remove.
https://review.coreboot.org/#/c/31554/3/src/southbridge/amd/pi/hudson/acpi/f... File src/southbridge/amd/pi/hudson/acpi/fch.asl:
https://review.coreboot.org/#/c/31554/3/src/southbridge/amd/pi/hudson/acpi/f... PS3, Line 141: /* TODO: It is unstable. */ This may actually relate to the problem IASL sees. Maybe amend the comment "might be fixed by restructuring".
https://review.coreboot.org/#/c/31554/3/src/southbridge/amd/pi/hudson/acpi/f... PS3, Line 163: // #include "acpi/AmdImc.asl" /* Hudson IMC function */ Please remove.
Hello Kyösti Mälkki, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31554
to look at the new patch set (#4).
Change subject: sb/amd/hudson/acpi: Fix illegal object references in 'fch.asl' file ......................................................................
sb/amd/hudson/acpi: Fix illegal object references in 'fch.asl' file
Issue spotted using IASL 20190215 on mainboard GIZMOSPHERE_GIZMO2: "Object is created temporarily in another method and cannot be accessed"
Change-Id: I1e4ca2c765083db3a27e415d3a69bef0912a606b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/acpi/fch.asl M src/southbridge/amd/pi/hudson/acpi/fch.asl 2 files changed, 9 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/31554/4
Hello Kyösti Mälkki, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31554
to look at the new patch set (#5).
Change subject: sb/amd/hudson/acpi: Fix illegal object references ......................................................................
sb/amd/hudson/acpi: Fix illegal object references
Issue spotted using IASL 20190215 on mainboard GIZMOSPHERE_GIZMO2: "Object is created temporarily in another method and cannot be accessed"
Change-Id: I1e4ca2c765083db3a27e415d3a69bef0912a606b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/acpi/fch.asl M src/southbridge/amd/pi/hudson/acpi/fch.asl 2 files changed, 9 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/31554/5
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31554 )
Change subject: sb/amd/hudson/acpi: Fix illegal object references ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31554/5/src/southbridge/amd/agesa/hudson/acp... File src/southbridge/amd/agesa/hudson/acpi/fch.asl:
https://review.coreboot.org/#/c/31554/5/src/southbridge/amd/agesa/hudson/acp... PS5, Line 159: #endif Please move above the comment.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31554 )
Change subject: sb/amd/hudson/acpi: Fix illegal object references ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31554/5/src/southbridge/amd/agesa/hudson/acp... File src/southbridge/amd/agesa/hudson/acpi/fch.asl:
https://review.coreboot.org/#/c/31554/5/src/southbridge/amd/agesa/hudson/acp... PS5, Line 159: #endif
Please move above the comment.
Done
Hello Kyösti Mälkki, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31554
to look at the new patch set (#6).
Change subject: sb/amd/hudson/acpi: Fix illegal object references ......................................................................
sb/amd/hudson/acpi: Fix illegal object references
Issue spotted using IASL 20190215 on mainboard GIZMOSPHERE_GIZMO2: "Object is created temporarily in another method and cannot be accessed"
Change-Id: I1e4ca2c765083db3a27e415d3a69bef0912a606b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/acpi/fch.asl M src/southbridge/amd/pi/hudson/acpi/fch.asl 2 files changed, 11 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/31554/6
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31554 )
Change subject: sb/amd/hudson/acpi: Fix illegal object references ......................................................................
Patch Set 6: Code-Review+2
thanks
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31554 )
Change subject: sb/amd/hudson/acpi: Fix illegal object references ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31554 )
Change subject: sb/amd/hudson/acpi: Fix illegal object references ......................................................................
sb/amd/hudson/acpi: Fix illegal object references
Issue spotted using IASL 20190215 on mainboard GIZMOSPHERE_GIZMO2: "Object is created temporarily in another method and cannot be accessed"
Change-Id: I1e4ca2c765083db3a27e415d3a69bef0912a606b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/31554 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/southbridge/amd/agesa/hudson/acpi/fch.asl M src/southbridge/amd/pi/hudson/acpi/fch.asl 2 files changed, 11 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Nico Huber: Looks good to me, approved
diff --git a/src/southbridge/amd/agesa/hudson/acpi/fch.asl b/src/southbridge/amd/agesa/hudson/acpi/fch.asl index 4d53051..83e3410 100644 --- a/src/southbridge/amd/agesa/hudson/acpi/fch.asl +++ b/src/southbridge/amd/agesa/hudson/acpi/fch.asl @@ -146,6 +146,10 @@ Return(CRES) /* note to change the Name buffer */ } /* end of Method(_SB.PCI0._CRS) */
+#if IS_ENABLED(CONFIG_HUDSON_IMC_FWM) + #include "acpi/AmdImc.asl" /* Hudson IMC function */ +#endif + /* * * FIRST METHOD CALLED UPON BOOT @@ -172,7 +176,6 @@ OSFL()
#if IS_ENABLED(CONFIG_HUDSON_IMC_FWM) - #include "acpi/AmdImc.asl" /* Hudson IMC function */ #if IS_ENABLED(CONFIG_ACPI_ENABLE_THERMAL_ZONE) ITZE() /* enable IMC Fan Control*/ #endif diff --git a/src/southbridge/amd/pi/hudson/acpi/fch.asl b/src/southbridge/amd/pi/hudson/acpi/fch.asl index 0c6e768..17f5140 100644 --- a/src/southbridge/amd/pi/hudson/acpi/fch.asl +++ b/src/southbridge/amd/pi/hudson/acpi/fch.asl @@ -129,6 +129,13 @@ Return(CRES) /* note to change the Name buffer */ } /* end of Method(_SB.PCI0._CRS) */
+#if IS_ENABLED(CONFIG_HUDSON_IMC_FWM) + /* TODO: It is unstable. + * might be fixed by restructuring + */ + #include "acpi/AmdImc.asl" /* Hudson IMC function */ +#endif + /* * * FIRST METHOD CALLED UPON BOOT @@ -155,8 +162,6 @@ OSFL()
#if IS_ENABLED(CONFIG_HUDSON_IMC_FWM) - /* TODO: It is unstable. */ - #include "acpi/AmdImc.asl" /* Hudson IMC function */ #if IS_ENABLED(CONFIG_ACPI_ENABLE_THERMAL_ZONE) ITZE() /* enable IMC Fan Control*/ #endif
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)