Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78990?usp=email )
Change subject: include/device/device: drop HAVE_ACPI_TABLES guards ......................................................................
include/device/device: drop HAVE_ACPI_TABLES guards
There's no need to remove the corresponding fields from the device_operations struct when HAVE_ACPI_TABLES isn't selected.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Iac20b6cdc44a5280566ee7003a5ef6fbe913b099 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78990 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/device/device.h 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/include/device/device.h b/src/include/device/device.h index 07b71ec..113969c 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -53,7 +53,6 @@ unsigned long *current); void (*get_smbios_strings)(struct device *dev, struct smbios_type11 *t);
-#if CONFIG(HAVE_ACPI_TABLES) unsigned long (*write_acpi_tables)(const struct device *dev, unsigned long start, struct acpi_rsdp *rsdp); void (*acpi_fill_ssdt)(const struct device *dev); @@ -61,7 +60,7 @@ const char *(*acpi_name)(const struct device *dev); /* Returns the optional _HID (Hardware ID) */ const char *(*acpi_hid)(const struct device *dev); -#endif + const struct pci_operations *ops_pci; const struct i2c_bus_operations *ops_i2c_bus; const struct spi_bus_operations *ops_spi_bus;