Attention is currently required from: Chen-Tsung Hsieh, Derek Huang, Ian Feng, Kenny Pan, Nick Vaccaro, Rex Chou, Shou-Chieh Hsu, Subrata Banik.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78147?usp=email )
Change subject: mb/google/nissa/var/craaskov: Modify GPIOs to remove TOF function
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/craaskov/gpio.c:
https://review.coreboot.org/c/coreboot/+/78147/comment/8692cd1b_a79148be :
PS1, Line 14: /* B5 : GPP_B5 ==> NC */
Here is disable i2c bus, should we also disable i2c bus in overridetree.cb?
```
.i2c[2] = {
.speed = I2C_SPEED_FAST,
.speed_config[0] = {
.speed = I2C_SPEED_FAST,
.scl_lcnt = 158,
.scl_hcnt = 79,
.sda_hold = 7,
}
},
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78147?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1ae6a6562d87f8da5f41691a7606a1aa10989443
Gerrit-Change-Number: 78147
Gerrit-PatchSet: 1
Gerrit-Owner: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-Reviewer: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Kenny Pan
kennypan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Kenny Pan
kennypan@google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Fri, 13 Oct 2023 02:26:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment