Change in coreboot[master]: nb/intel/i440bx: Resolve a SMP-raminit TODO

[Keith Hui (Code Review)]

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40957 )

Change subject: nb/intel/i440bx: Resolve a SMP-raminit TODO
......................................................................

nb/intel/i440bx: Resolve a SMP-raminit TODO

Change-Id: I0087294bccee079368c93ba8986873a5e65593b0
Signed-off-by: Keith Hui 
---
M src/northbridge/intel/i440bx/raminit.c
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/40957/1

diff --git a/src/northbridge/intel/i440bx/raminit.c b/src/northbridge/intel/i440bx/raminit.c
index dddcc21..ee1e759 100644
--- a/src/northbridge/intel/i440bx/raminit.c
+++ b/src/northbridge/intel/i440bx/raminit.c
@@ -123,8 +123,11 @@
     * [01:00] Reserved
     */
    NBXCFG + 0, 0x0c,
-	// TODO: Bit 15 should be 0 for multiprocessor boards
+#if CONFIG(SMP)
+	NBXCFG + 1, 0x00,
+#else
    NBXCFG + 1, 0x80,
+#endif
    NBXCFG + 2, 0x00,
    NBXCFG + 3, 0xff,

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40957 )

Change subject: nb/intel/i440bx: Resolve a SMP-raminit TODO
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40957 )

Change subject: nb/intel/i440bx: Resolve a SMP-raminit TODO
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40957 )

Change subject: nb/intel/i440bx: Resolve a SMP-raminit TODO
......................................................................

nb/intel/i440bx: Resolve a SMP-raminit TODO

Change-Id: I0087294bccee079368c93ba8986873a5e65593b0
Signed-off-by: Keith Hui 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40957
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans 
Reviewed-by: Angel Pons 
---
M src/northbridge/intel/i440bx/raminit.c
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/northbridge/intel/i440bx/raminit.c b/src/northbridge/intel/i440bx/raminit.c
index dddcc21..ee1e759 100644
--- a/src/northbridge/intel/i440bx/raminit.c
+++ b/src/northbridge/intel/i440bx/raminit.c
@@ -123,8 +123,11 @@
     * [01:00] Reserved
     */
    NBXCFG + 0, 0x0c,
-	// TODO: Bit 15 should be 0 for multiprocessor boards
+#if CONFIG(SMP)
+	NBXCFG + 1, 0x00,
+#else
    NBXCFG + 1, 0x80,
+#endif
    NBXCFG + 2, 0x00,
    NBXCFG + 3, 0xff,