Attention is currently required from: Arthur Heymans, Cliff Huang, Jincheng Li, Lance Zhao, Tim Wawrzynczak.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81373?usp=email )
Change subject: acpi: Add soc_pci_domain_fill_ssdt
......................................................................
Patch Set 2:
(1 comment)
File src/acpi/acpigen_pci_root_resource_producer.c:
https://review.coreboot.org/c/coreboot/+/81373/comment/6bcc5bea_c145370a :
PS1, Line 49: /* SoC specific settings, device object creation could be placed here */
: soc_pci_domain_fill_ssdt(domain);
I don't think a soc specific way of creating objects is the way to go. […]
We need this for GNR codes to cover GNR and SRF, and SPR will also benefit due to the reason of multiple SKU. I agree that this should not be a must, it is just an options. For clients, embedded, static generation should be the default way.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81373?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I893eb64c776e78f46737072b475acde5e32a796a
Gerrit-Change-Number: 81373
Gerrit-PatchSet: 2
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Comment-Date: Thu, 21 Mar 2024 12:11:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment