Attention is currently required from: char, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72827 )
Change subject: superio/ite: Add support for ITE IT8987e ......................................................................
Patch Set 5:
(5 comments)
File src/superio/ite/it8987e/superio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169935): https://review.coreboot.org/c/coreboot/+/72827/comment/8d48a568_5dede266 PS5, Line 18: if (!dev->enabled) suspect code indent for conditional statements (8, 24)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169935): https://review.coreboot.org/c/coreboot/+/72827/comment/62ddfd97_e5146349 PS5, Line 21: switch (dev->path.pnp.device) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169935): https://review.coreboot.org/c/coreboot/+/72827/comment/5fb3fab2_19c8b7d2 PS5, Line 49: PNP_MSC0 | PNP_MSC1 | PNP_MSC2, 0xfffe, 0xfffe, 0xfffe, 0xfffe}, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169935): https://review.coreboot.org/c/coreboot/+/72827/comment/2a03f8a9_09c9e348 PS5, Line 49: PNP_MSC0 | PNP_MSC1 | PNP_MSC2, 0xfffe, 0xfffe, 0xfffe, 0xfffe}, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169935): https://review.coreboot.org/c/coreboot/+/72827/comment/ebc1aeeb_b635a4cc PS5, Line 71: } else { suspect code indent for conditional statements (8, 24)
-
build bot (Jenkins) (Code Review)