Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58640 )
Change subject: soc/mediatek/mt8186: Add a stub implementation of the MT8186 SoC
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58640/comment/37d44b0c_22a4da4a
PS2, Line 10:
this doesn't look like a copy of the previous soc's directory, so i don't think that the questions a […]
Indeed. Currently we have MT8173, MT8183, MT8192 and MT8195. How does the new chip fit in there? What differences are there that the support cannot be integrated into existing code?
Also please mention the datasheet name and revision in the commit message.
https://review.coreboot.org/c/coreboot/+/58640/comment/5ced09f5_b3d5ad44
PS2, Line 11: TEST=boot from SPI-NOR and show uart log
Tested on what board?
File src/soc/mediatek/mt8186/include/soc/timer.h:
PS2:
This is the same as `mt8195/include/soc/timer.h` for example.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I579f79c15f4bf5e1daf6b35c70cfd00a985a0b81
Gerrit-Change-Number: 58640
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 29 Oct 2021 15:00:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment