Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44405 )
Change subject: mb/google/zork: adjust i2c2 data hold time for TP ......................................................................
mb/google/zork: adjust i2c2 data hold time for TP
current setting got 0.278us which is less than the min 0.3us. increase i2c2 data hold time for TP.
BUG=b:163613330 BRANCH=master TEST=1. emerge-zork coreboot chromeos-bootimage 2. data hold time measured by scope: 0.3805us
Change-Id: I2d564983383c17ed43cc5cc5aaff0fcd67ce6928 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/44405/1
diff --git a/src/mainboard/google/zork/variants/berknip/overridetree.cb b/src/mainboard/google/zork/variants/berknip/overridetree.cb index f0f92c5..aa248b6 100644 --- a/src/mainboard/google/zork/variants/berknip/overridetree.cb +++ b/src/mainboard/google/zork/variants/berknip/overridetree.cb @@ -27,6 +27,7 @@ .speed = I2C_SPEED_FAST, .rise_time_ns = 3, .fall_time_ns = 2, + .data_hold_time_ns = 400, }"
# Enable I2C3 for H1 400kHz
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44405 )
Change subject: mb/google/zork: adjust i2c2 data hold time for TP ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44405 )
Change subject: mb/google/zork: adjust i2c2 data hold time for TP ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44405/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44405/1//COMMIT_MSG@7 PS1, Line 7: TP This satisfies the timing requirement for touchscreen as well, right? (Since they are both sharing the same bus)
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44405 )
Change subject: mb/google/zork: adjust i2c2 data hold time for TP ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44405/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44405/1//COMMIT_MSG@7 PS1, Line 7: TP
This satisfies the timing requirement for touchscreen as well, right? (Since they are both sharing t […]
Hi Furquan, yes
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44405 )
Change subject: mb/google/zork: adjust i2c2 data hold time for TP ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44405/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44405/1//COMMIT_MSG@7 PS1, Line 7: TP
Hi Furquan, yes
Thanks!
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44405 )
Change subject: mb/google/zork: adjust i2c2 data hold time for TP ......................................................................
mb/google/zork: adjust i2c2 data hold time for TP
current setting got 0.278us which is less than the min 0.3us. increase i2c2 data hold time for TP.
BUG=b:163613330 BRANCH=master TEST=1. emerge-zork coreboot chromeos-bootimage 2. data hold time measured by scope: 0.3805us
Change-Id: I2d564983383c17ed43cc5cc5aaff0fcd67ce6928 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44405 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/berknip/overridetree.cb b/src/mainboard/google/zork/variants/berknip/overridetree.cb index f0f92c5..aa248b6 100644 --- a/src/mainboard/google/zork/variants/berknip/overridetree.cb +++ b/src/mainboard/google/zork/variants/berknip/overridetree.cb @@ -27,6 +27,7 @@ .speed = I2C_SPEED_FAST, .rise_time_ns = 3, .fall_time_ns = 2, + .data_hold_time_ns = 400, }"
# Enable I2C3 for H1 400kHz
-
Furquan Shaikh (Code Review) -
Kevin Chiu (Code Review)
-
Patrick Georgi (Code Review)