Attention is currently required from: Paul Menzel, Jon Murphy, Rob Barnes.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59813 )
Change subject: mb/google/guybrush: Configure EN_SPKR GPIO in PSP verstage
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59813/comment/755e4c82_e0bc8c31
PS1, Line 13: mechanical off(G3)
Please add a space before the (.
Done
https://review.coreboot.org/c/coreboot/+/59813/comment/26a9b4b7_39d1329c
PS1, Line 17: EN_SPKR GPIO(in S5 domain)
Please add a space before the (.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59813
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a52a167da9c7040731da5d355ec345fd9b13762
Gerrit-Change-Number: 59813
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Thu, 02 Dec 2021 00:33:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment