Attention is currently required from: Wonkyu Kim, Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, Angel Pons, Patrick Rudolph.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60989 )
Change subject: soc/intel: Abstract the common block API for TCSS registers access
......................................................................
Patch Set 13:
(1 comment)
File src/soc/intel/common/block/usb4/usb4.c:
https://review.coreboot.org/c/coreboot/+/60989/comment/0dd157a8_bba8e1d8
PS13, Line 32: tcss_valid_tbt_auth
wondering if USB4 common code has dependency over tcss/tcss. […]
USB4 common code already has a few Kconfig for the generic SSDT. IMR is only one feature which would need to be determined differently across platforms(ADL/MTL/TGL, etc) through the tcss_valid_tbt_auth().
CpuPcieRpEnableMask is not relevant here for USB4 and is applicable all the way through devicetree->fsp programming the IOM_TCSS_DEVEN regsiter. After booting to kernel, Coreboot acpi code fetches the above register setting and informs kernel about TypeC ports availability through the _STA method.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60989
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e2696b117af24412d73b257f470efc40caa5022
Gerrit-Change-Number: 60989
Gerrit-PatchSet: 13
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 23 Jan 2022 21:09:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment