Attention is currently required from: David Wu, Eran Mitrani, Felix Held, Kapil Porwal, Lucas Chen, Matt DeVillier, Ren Kuo, Subrata Banik, Tarun, Tyler Wang.
Hello David Wu, Eran Mitrani, Kapil Porwal, Lucas Chen, Matt DeVillier, Ren Kuo, Subrata Banik, Tarun, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78254?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+2 by David Wu, Code-Review+2 by Subrata Banik, Code-Review-1 by Matt DeVillier, Verified+1 by build bot (Jenkins)
Change subject: mb/google/rex/var/karis: Set touchscreen power/reset GPIOs correctly
......................................................................
mb/google/rex/var/karis: Set touchscreen power/reset GPIOs correctly
The tochscreen isn't powered on yet when the detection is done, it
makes touchscren no function.
Set touchscreen power and reset GPIOs correctly in romstage and
ramstage to make the detect feature works.
BUG=b:303130400
TEST=(1) emerge-rex coreboot
(2) Test on karis, touchscreen function works
Change-Id: I6c7815b81eb47fb41e58233fde512ac6b9c000a7
Signed-off-by: Tyler Wang tyler.wang@quanta.corp-partner.google.com
---
M src/mainboard/google/rex/variants/karis/gpio.c
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/78254/6
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78254?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6c7815b81eb47fb41e58233fde512ac6b9c000a7
Gerrit-Change-Number: 78254
Gerrit-PatchSet: 6
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lucas Chen
lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Lucas Chen
lucas.chen@quanta.corp-partner.google.com
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: newpatchset