Change in coreboot[master]: soc/intel/common/../car: Add CAR debug Kconfig CAR_DEBUG - coreboot-gerrit

20 Jun 2021


      Attention is currently required from: Subrata Banik, Patrick Rudolph.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55653 )
Change subject: soc/intel/common/../car: Add CAR debug Kconfig CAR_DEBUG
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/55653/comment/b04758ed_72d6eb56 
PS1, Line 453: void report_cache_info(void)
can we split the cache info reporting and copy test into 2 separate functions?
Also, i think cache info can be printed by default and not as debug, what do you think?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55653
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb1e644f154b8f8d8da41ba8084e99827e7eff23
Gerrit-Change-Number: 55653
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Mon, 21 Jun 2021 05:40:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment