Attention is currently required from: Caveh Jalali, Matt DeVillier, Boris Mittelberg.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74603 )
Change subject: [WIP] mb/google/link: Use chromeec_smi_sleep() ......................................................................
Patch Set 1:
(1 comment)
File src/ec/google/chromeec/smihandler.c:
https://review.coreboot.org/c/coreboot/+/74603/comment/a5274370_47358554 PS1, Line 67: ACPI_S4
changes to this file seem unintentional
It's intentional here in the sense it should be discussed. While it may be that Chromebooks in their original ChromeOS installation do not support S4 suspend-to-disk, is there a reason why S4 could not be supported?
If we advertise S4 as an allowed sleepstate, we would want the EC and USB port powers to behave here the same way as in S5 ?
-
Kyösti Mälkki (Code Review)