Attention is currently required from: Kane Chen.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64467 )
Change subject: cpu/x86/mtrr: Print cpu index number when set up MTRRs for BSP/APs
......................................................................
Patch Set 7:
(2 comments)
Patchset:
PS7:
IMO I would just revert this patch
i'd prefer to get the fix CB:70797 upstream instead of doing a revert
File src/cpu/x86/mtrr/mtrr.c:
https://review.coreboot.org/c/coreboot/+/64467/comment/9ae229ea_5284dc8c
PS3, Line 358: lapicid
i checked cpu_index function, there is loop inside to compare apic id. i feel it's too much. […]
cpu_index won't work before mpinit. pushed CB:70797 that changes this back to using the lapicid call so it won't break things when printing the mtrr configuration before mpinit while still printing at least some info on which cpu this is running
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64467
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1
Gerrit-Change-Number: 64467
Gerrit-PatchSet: 7
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 14 Dec 2022 22:34:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Kane Chen
kane.chen@intel.com
Gerrit-MessageType: comment