Hello Aaron Durbin, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/18982
to look at the new patch set (#3).
Change subject: vboot: Compile bootmode.c conditionally based on CONFIG_VBOOT ......................................................................
vboot: Compile bootmode.c conditionally based on CONFIG_VBOOT
Currently, src/vboot/bootmode.c gets compiled even if vboot is disabled. It seems that this was only done to support calling certain developer/recovery mode functions in this case. There is no reason to compile the whole file for that -- we can just differentiate with a stub in the header instead, which is what other parts of coreboot usually do for cases like this.
Change-Id: If83e1b3e0f34f75c2395b4c464651e373724b2e6 Signed-off-by: Julius Werner jwerner@chromium.org --- M src/vboot/Makefile.inc M src/vboot/bootmode.c M src/vboot/vboot_common.h 3 files changed, 8 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/18982/3