Lucas Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43995 )
Change subject: mb/google/zork/var: Add gpio change support to v3.61 ......................................................................
mb/google/zork/var: Add gpio change support to v3.61
Add gpio change support to schematic v3.61 for trembyle variants. gpio90 EN_PWR_TOUCHSCREEN gpio29 HP_INT_ODL_R gpio89 NC
BUG=b:161447996, b:162021274 TEST:none
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: I74e0fd9139463961bb3fa99dc94684c147965f60 --- M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c M src/mainboard/google/zork/variants/berknip/gpio.c M src/mainboard/google/zork/variants/ezkinil/gpio.c M src/mainboard/google/zork/variants/morphius/gpio.c M src/mainboard/google/zork/variants/trembyle/gpio.c 5 files changed, 23 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/43995/1
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c index c10c9f4..796840e 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c @@ -65,8 +65,8 @@ /* PCIE_RST1_L (unused) */ PAD_NC(GPIO_27), /* GPIO_28: Not available */ - /* GPIO_29: unused */ - PAD_NC(GPIO_29), + /* GPIO_29: HP_INT_ODL_R */ + PAD_GPI(GPIO_29, PULL_NONE), /* FCH_ESPI_EC_CS_L */ PAD_NF(GPIO_30, ESPI_CS_L, PULL_NONE), /* EC_AP_INT_ODL (Sensor Framesync) */ @@ -109,10 +109,10 @@ PAD_NF(GPIO_87, EMMC_DATA7, PULL_NONE), /* EMMC_DATA5 */ PAD_NF(GPIO_88, EMMC_DATA5, PULL_NONE), - /* EN_DEV_BEEP_L */ - PAD_GPO(GPIO_89, HIGH), - /* Testpoint */ - PAD_NC(GPIO_90), + /* GPIO89: NC */ + PAD_NC(GPIO_89), + /* GPIO90: EN_PWR_TOUCHSCREEN */ + PAD_GPO(GPIO_90, HIGH), /* EN_SPKR */ PAD_GPO(GPIO_91, LOW), /* CLK_REQ0_L - WIFI */ diff --git a/src/mainboard/google/zork/variants/berknip/gpio.c b/src/mainboard/google/zork/variants/berknip/gpio.c index 08b1c4d..d1088d6 100644 --- a/src/mainboard/google/zork/variants/berknip/gpio.c +++ b/src/mainboard/google/zork/variants/berknip/gpio.c @@ -22,6 +22,8 @@ PAD_GPI(GPIO_86, PULL_NONE), /* MST_GPIO_3 (Fw Update HDMI hub) */ PAD_GPI(GPIO_90, PULL_NONE), + /* EN_DEV_BEEP_L */ + PAD_GPO(GPIO_89, HIGH), };
const struct soc_amd_gpio *variant_override_gpio_table(size_t *size) diff --git a/src/mainboard/google/zork/variants/ezkinil/gpio.c b/src/mainboard/google/zork/variants/ezkinil/gpio.c index 053c3c8..0f161e4 100644 --- a/src/mainboard/google/zork/variants/ezkinil/gpio.c +++ b/src/mainboard/google/zork/variants/ezkinil/gpio.c @@ -22,6 +22,8 @@ PAD_GPI(GPIO_86, PULL_NONE), /* MST_GPIO_3 (Fw Update HDMI hub) */ PAD_GPI(GPIO_90, PULL_NONE), + /* EN_DEV_BEEP_L */ + PAD_GPO(GPIO_89, HIGH), };
static const struct soc_amd_gpio ezkinil_bid2_gpio_set_stage_ram[] = { @@ -37,6 +39,11 @@ PAD_NC(GPIO_69), /* MST_GPIO_2 (Fw Update HDMI hub) Change NC */ PAD_NC(GPIO_86), + /* EN_DEV_BEEP_L */ + PAD_GPO(GPIO_89, HIGH), + /* Testpoint */ + PAD_NC(GPIO_90), + };
static const struct soc_amd_gpio ezkinil_bid3_gpio_set_stage_ram[] = { diff --git a/src/mainboard/google/zork/variants/morphius/gpio.c b/src/mainboard/google/zork/variants/morphius/gpio.c index 074fe00..d2e54e0 100644 --- a/src/mainboard/google/zork/variants/morphius/gpio.c +++ b/src/mainboard/google/zork/variants/morphius/gpio.c @@ -24,6 +24,8 @@ PAD_GPI(GPIO_86, PULL_NONE), /* MST_GPIO_3 (Fw Update HDMI hub) */ PAD_GPI(GPIO_90, PULL_NONE), + /* EN_DEV_BEEP_L */ + PAD_GPO(GPIO_89, HIGH), };
static const struct soc_amd_gpio morphius_bid2_gpio_set_stage_ram[] = { @@ -41,6 +43,8 @@ PAD_GPI(GPIO_86, PULL_NONE), /* MST_GPIO_3 (Fw Update HDMI hub) */ PAD_GPI(GPIO_90, PULL_NONE), + /* EN_DEV_BEEP_L */ + PAD_GPO(GPIO_89, HIGH), };
const struct soc_amd_gpio *variant_override_gpio_table(size_t *size) diff --git a/src/mainboard/google/zork/variants/trembyle/gpio.c b/src/mainboard/google/zork/variants/trembyle/gpio.c index d8367e7..c2ad2f9 100644 --- a/src/mainboard/google/zork/variants/trembyle/gpio.c +++ b/src/mainboard/google/zork/variants/trembyle/gpio.c @@ -24,6 +24,8 @@ PAD_GPI(GPIO_86, PULL_NONE), /* MST_GPIO_3 (Fw Update HDMI hub) */ PAD_GPI(GPIO_90, PULL_NONE), + /* EN_DEV_BEEP_L */ + PAD_GPO(GPIO_89, HIGH), };
static const struct soc_amd_gpio trembyle_bid3_gpio_set_stage_ram[] = { @@ -41,6 +43,8 @@ PAD_GPI(GPIO_86, PULL_NONE), /* MST_GPIO_3 (Fw Update HDMI hub) */ PAD_GPI(GPIO_90, PULL_NONE), + /* EN_DEV_BEEP_L */ + PAD_GPO(GPIO_89, HIGH), };
const struct soc_amd_gpio *variant_override_gpio_table(size_t *size)
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43995 )
Change subject: mb/google/zork/var: Add gpio change support to v3.61 ......................................................................
Patch Set 1:
(2 comments)
Thanks for pushing this change Lucas. There are some paths in devicetree/ACPI that need to be handled dynamically at runtime as well. Josie is currently working on adding some Kconfigs and helper functions to facilitate this.
https://review.coreboot.org/c/coreboot/+/43995/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/43995/1/src/mainboard/google/zork/v... PS1, Line 68: HP_INT_ODL_R There is some more work required here to ensure that devicetree exposes the correct irq_gpio depending upon the board id. Josie is working on adding Kconfig and some helper functions to take care of that.
https://review.coreboot.org/c/coreboot/+/43995/1/src/mainboard/google/zork/v... PS1, Line 115: HIGH This will have to be set to HIGH as part of ACPI power resources and hence here it will have to be set to LOW. This will require changes in all overridetrees as well.
Hello build bot (Jenkins), Josie Nordrum,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43995
to look at the new patch set (#2).
Change subject: mb/google/zork/var: Add gpio change support to v3.61 ......................................................................
mb/google/zork/var: Add gpio change support to v3.61
Add gpio change support to schematic v3.61 for trembyle variants. gpio90 EN_PWR_TOUCHSCREEN gpio29 HP_INT_ODL_R gpio89 NC
BUG=b:161447996, b:162021274 TEST:none
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: I74e0fd9139463961bb3fa99dc94684c147965f60 --- M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c M src/mainboard/google/zork/variants/berknip/gpio.c M src/mainboard/google/zork/variants/ezkinil/gpio.c M src/mainboard/google/zork/variants/morphius/gpio.c M src/mainboard/google/zork/variants/trembyle/gpio.c 5 files changed, 23 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/43995/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43995 )
Change subject: mb/google/zork/var: Add gpio change support to v3.61 ......................................................................
Patch Set 2:
Lucas - Josie has started pushing changes for v3.6+ here: https://review.coreboot.org/c/coreboot/+/44156
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43995 )
Change subject: mb/google/zork/var: Add gpio change support to v3.61 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43995/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43995/2//COMMIT_MSG@9 PS2, Line 9: gpio change Sorry, what is “gpio change”?
Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43995 )
Change subject: mb/google/zork/var: Add gpio change support to v3.61 ......................................................................
Patch Set 2: Code-Review-1
Lucas Chen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43995 )
Change subject: mb/google/zork/var: Add gpio change support to v3.61 ......................................................................
Abandoned
-
Furquan Shaikh (Code Review) -
Lucas Chen (Code Review)
-
Paul Menzel (Code Review)