Attention is currently required from: Michał Żygowski, Elyes Haouas, Felix Held, Piotr Król.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70255 )
Change subject: superio/nuvoton/nct5104d/chip.h: Use 'bool' when appropriate
......................................................................
Patch Set 1:
(1 comment)
File src/superio/nuvoton/nct5104d/superio.c:
https://review.coreboot.org/c/coreboot/+/70255/comment/7ef3f89c_9a4a63f9
PS1, Line 176: conf->irq_trigger_type != false
equal to !conf->irq_trigger_type ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70255
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb321302bc82eb1b73bc1e732b82b9f726d2f363
Gerrit-Change-Number: 70255
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Fri, 02 Dec 2022 08:22:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment