Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31113
Change subject: soc/intel/{apl,skl}: Drop redundant `select RTC` ......................................................................
soc/intel/{apl,skl}: Drop redundant `select RTC`
RTC is now implicitly selected through SOC_INTEL_COMMON_BLOCK_RTC and SOC_INTEL_COMMON_PCH_BASE.
Change-Id: I1885c419cfe318b75f3bda6220d4a6f6a8e26575 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/soc/intel/apollolake/Kconfig M src/soc/intel/skylake/Kconfig 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/31113/1
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index cebfc6f..19cd296 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -62,7 +62,6 @@ select PMC_INVALID_READ_AFTER_WRITE select PMC_GLOBAL_RESET_ENABLE_LOCK select REG_SCRIPT - select RTC select SMM_TSEG select SA_ENABLE_IMR select SOC_INTEL_COMMON diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index 442b09a..ec982d1 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -42,7 +42,6 @@ select PARALLEL_MP_AP_WORK select PCIEX_LENGTH_64MB select REG_SCRIPT - select RTC select SA_ENABLE_DPR select SMM_TSEG select SMP
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31113 )
Change subject: soc/intel/{apl,skl}: Drop redundant `select RTC` ......................................................................
Patch Set 1: Code-Review+2
NB this depends on another patch
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31113 )
Change subject: soc/intel/{apl,skl}: Drop redundant `select RTC` ......................................................................
Patch Set 1: Code-Review+2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31113 )
Change subject: soc/intel/{apl,skl}: Drop redundant `select RTC` ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31113 )
Change subject: soc/intel/{apl,skl}: Drop redundant `select RTC` ......................................................................
soc/intel/{apl,skl}: Drop redundant `select RTC`
RTC is now implicitly selected through SOC_INTEL_COMMON_BLOCK_RTC and SOC_INTEL_COMMON_PCH_BASE.
Change-Id: I1885c419cfe318b75f3bda6220d4a6f6a8e26575 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/31113 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Lijian Zhao lijian.zhao@intel.com Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/apollolake/Kconfig M src/soc/intel/skylake/Kconfig 2 files changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved Subrata Banik: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index cebfc6f..19cd296 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -62,7 +62,6 @@ select PMC_INVALID_READ_AFTER_WRITE select PMC_GLOBAL_RESET_ENABLE_LOCK select REG_SCRIPT - select RTC select SMM_TSEG select SA_ENABLE_IMR select SOC_INTEL_COMMON diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index 442b09a..ec982d1 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -42,7 +42,6 @@ select PARALLEL_MP_AP_WORK select PCIEX_LENGTH_64MB select REG_SCRIPT - select RTC select SA_ENABLE_DPR select SMM_TSEG select SMP
-
Angel Pons (Code Review) -
Lijian Zhao (Code Review)
-
Nico Huber (Code Review)
-
Subrata Banik (Code Review)