Attention is currently required from: Paul Menzel, Angel Pons, Arthur Heymans. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58934 )
Change subject: Documentation/coding_style.md: Avoid weakly linked symbols ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
In case you're curious, CB:59768 is an example where using weak stubs is a bad idea.
I'm not sure I really agree with your concerns there. You're just worried that someone would forget to override the weak symbol when they should have? But how does adding a Kconfig fix that? They might just as well forget to set that Kconfig and get the same result.
I don't really think this poses any more of a risk than "someone might put the wrong bus number into Kconfig and then it's broken". At some point, you can't really prevent people from doing the wrong thing (and in this case, presumably someone would notice very quickly that their TPM communication doesn't work if that's a feature they care about... it doesn't really look like the silent, insidious kind of bug). I would say this is a gray area where either version works, but I don't think it's really an example of weak symbols having terrible consequences.
-
Julius Werner (Code Review)