Attention is currently required from: Martin Roth, Andy Yeh, Rizwan Qureshi.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50261 )
Change subject: mb/google/dedede/var/magolor: Enable dynamic SSDT generation
......................................................................
Patch Set 8:
(2 comments)
File src/mainboard/google/dedede/variants/magolor/camera_config.c:
https://review.coreboot.org/c/coreboot/+/50261/comment/637ba3a5_12b487cb
PS8, Line 17: {
open brace '{' following union go on the same line
https://review.coreboot.org/c/coreboot/+/50261/comment/4dcb919d_5a881d14
PS8, Line 19: {
open brace '{' following struct go on the same line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50261
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I764abf70bacbe61452e7b0fd59c1b375227b5748
Gerrit-Change-Number: 50261
Gerrit-PatchSet: 8
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Andy Yeh
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Andy Yeh
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Comment-Date: Mon, 22 Mar 2021 15:39:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment