Hello Chris Wang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44264
to review the following change.
Change subject: mb/google/zork: add dptc interface support ......................................................................
mb/google/zork: add dptc interface support
add dptc support for tablet/clamshell mode
Profile 0 : clamshell mode Profile 1 : Tablet mode
BUG=b:157943445 BRANCH=none TEST=Build. check the setting changed.
Change-Id: I8f952d41ee90f0fdd0ecff9a4d50201f9ee9ce7c Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com --- M src/mainboard/google/zork/dsdt.asl A src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/dptc.asl A src/mainboard/google/zork/variants/berknip/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/dalboz/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/morphius/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/trembyle/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/dptc.asl 10 files changed, 63 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/44264/1
diff --git a/src/mainboard/google/zork/dsdt.asl b/src/mainboard/google/zork/dsdt.asl index 08ea5cf..2dc456d 100644 --- a/src/mainboard/google/zork/dsdt.asl +++ b/src/mainboard/google/zork/dsdt.asl @@ -35,6 +35,8 @@ /* global utility methods expected within the _SB scope */ #include <arch/x86/acpi/globutil.asl>
+ #include <variant/acpi/dptc.asl> + /* Describe the SOC */ #include <soc.asl>
diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/dptc.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/dptc.asl new file mode 100644 index 0000000..6732b24 --- /dev/null +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/dptc.asl @@ -0,0 +1,29 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#define DPTC_CTDP 0x0 +#define DPTC_STAPM_TIME_CONSTANT 0x1 +#define DPTC_SKIN_CONTROL_SCALAR 0x2 +#define DPTC_THERMAL_CONTROL_LIMIT 0x3 +#define DPTC_PACKAGE_POWER_LIMIT 0x4 +#define DPTC_SUSTAINED_POWER_LIMIT 0x5 +#define DPTC_FAST_PPT_LIMIT 0x6 +#define DPTC_SLOW_PPT_LIMIT 0x7 +#define DPTC_SLOW_PPT_TIME_CONSTANT 0x8 +#define DPTC_PROCHOT_L 0x9 +#define DPTC_SYS_TEMP_TRACKING 0xa +#define DPTC_VRM_CURRENT_LIMIT 0xb +#define DPTC_VRM_MAXIMUM_CURRENT_LIMIT 0xc +#define DPTC_VRM_LOW_POWER_THRESHOLD 0xd +#define DPTC_VRM_SOC_CURRENT_LIMIT 0xe +#define DPTC_VRM_SOC_LOW_POWER_THRESHOLD 0xf +#define DPTC_DGPU_CONTROL 0x10 + +External(_SB.ALIB, MethodObj) + +Method(POF0, 0, Serialized) { + return +} + +Method(POF1, 0, Serialized) { + return +} diff --git a/src/mainboard/google/zork/variants/berknip/include/variant/acpi/dptc.asl b/src/mainboard/google/zork/variants/berknip/include/variant/acpi/dptc.asl new file mode 100644 index 0000000..6eab4db --- /dev/null +++ b/src/mainboard/google/zork/variants/berknip/include/variant/acpi/dptc.asl @@ -0,0 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/dptc.asl> + diff --git a/src/mainboard/google/zork/variants/dalboz/include/variant/acpi/dptc.asl b/src/mainboard/google/zork/variants/dalboz/include/variant/acpi/dptc.asl new file mode 100644 index 0000000..6eab4db --- /dev/null +++ b/src/mainboard/google/zork/variants/dalboz/include/variant/acpi/dptc.asl @@ -0,0 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/dptc.asl> + diff --git a/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/dptc.asl b/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/dptc.asl new file mode 100644 index 0000000..6eab4db --- /dev/null +++ b/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/dptc.asl @@ -0,0 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/dptc.asl> + diff --git a/src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/dptc.asl b/src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/dptc.asl new file mode 100644 index 0000000..6eab4db --- /dev/null +++ b/src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/dptc.asl @@ -0,0 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/dptc.asl> + diff --git a/src/mainboard/google/zork/variants/morphius/include/variant/acpi/dptc.asl b/src/mainboard/google/zork/variants/morphius/include/variant/acpi/dptc.asl new file mode 100644 index 0000000..6eab4db --- /dev/null +++ b/src/mainboard/google/zork/variants/morphius/include/variant/acpi/dptc.asl @@ -0,0 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/dptc.asl> + diff --git a/src/mainboard/google/zork/variants/trembyle/include/variant/acpi/dptc.asl b/src/mainboard/google/zork/variants/trembyle/include/variant/acpi/dptc.asl new file mode 100644 index 0000000..6eab4db --- /dev/null +++ b/src/mainboard/google/zork/variants/trembyle/include/variant/acpi/dptc.asl @@ -0,0 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/dptc.asl> + diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/dptc.asl b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/dptc.asl new file mode 100644 index 0000000..6eab4db --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/dptc.asl @@ -0,0 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/dptc.asl> + diff --git a/src/mainboard/google/zork/variants/woomax/include/variant/acpi/dptc.asl b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/dptc.asl new file mode 100644 index 0000000..6eab4db --- /dev/null +++ b/src/mainboard/google/zork/variants/woomax/include/variant/acpi/dptc.asl @@ -0,0 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/dptc.asl> +
Hello Chris Wang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44264
to look at the new patch set (#2).
Change subject: mb/google/zork: add dptc interface support ......................................................................
mb/google/zork: add dptc interface support
add dptc support for tablet/clamshell mode
Profile 0 : clamshell mode Profile 1 : Tablet mode
BUG=b:157943445 BRANCH=none TEST=Build. check the setting changed.
Change-Id: I8f952d41ee90f0fdd0ecff9a4d50201f9ee9ce7c Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com --- M src/mainboard/google/zork/dsdt.asl A src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/dptc.asl A src/mainboard/google/zork/variants/berknip/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/dalboz/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/ezkinil/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/morphius/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/trembyle/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/dptc.asl A src/mainboard/google/zork/variants/woomax/include/variant/acpi/dptc.asl 10 files changed, 64 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/44264/2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44264 )
Change subject: mb/google/zork: add dptc interface support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44264/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/dptc.asl:
https://review.coreboot.org/c/coreboot/+/44264/2/src/mainboard/google/zork/v... PS2, Line 24: return These methods don't do anything? What is the purpose of these methods? And why is this file in mainboard? Do we expect the same logic across designs? If so, we should move it to soc?
chris wang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44264 )
Change subject: mb/google/zork: add dptc interface support ......................................................................
Abandoned
-
Aaron Durbin (Code Review) -
chris wang (Code Review)