Asami Doi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35024 )
Change subject: mainboard/emulation/qemu-aarch64: Update DRAM_SIZE_MB ......................................................................
mainboard/emulation/qemu-aarch64: Update DRAM_SIZE_MB
DRAM_SIZE_MB should be the maximum size (255GiB / -m 261120M) that’s possible with QEMU on AArch64 virt because it tries to search the DRAM_SIZE_MB range to find the true memory size.
Signed-off-by: Asami Doi d0iasm.pub@gmail.com Change-Id: Id479c0b18d1e1adceecdcca13e36119b95617e6d --- M Documentation/mainboard/emulation/qemu-aarch64.md M src/mainboard/emulation/qemu-aarch64/Kconfig 2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/35024/1
diff --git a/Documentation/mainboard/emulation/qemu-aarch64.md b/Documentation/mainboard/emulation/qemu-aarch64.md index ee4c9e7..4df36a9 100644 --- a/Documentation/mainboard/emulation/qemu-aarch64.md +++ b/Documentation/mainboard/emulation/qemu-aarch64.md @@ -7,7 +7,7 @@ ```bash qemu-system-aarch64 -bios ./build/coreboot.rom \ -M virt,secure=on,virtualization=on -cpu cortex-a53 \ - -nographic -m 8912M + -nographic -m 8192M ```
- The default CPU in QEMU for AArch64 is a cortex-a15 which is 32-bit @@ -17,6 +17,7 @@ via `-machine secure=on,virtualization=on`. - You need to specify the size of memory more than 544 MiB because 512 MiB is reserved for the kernel. +- The maximum size of memory is 255GiB (-m 261120).
## Building coreboot with an arbitrary FIT payload There are 3 steps to make coreboot.rom for QEMU/AArch64. If you select @@ -30,7 +31,7 @@ ``` $ qemu-system-aarch64 \ -M virt,dumpdtb=virt.dtb,secure=on,virtualization=on \ - -cpu cortex-a53 -nographic -m 2048M + -cpu cortex-a53 -nographic -m 8192M ```
### 2. Build a FIT image with a DTB diff --git a/src/mainboard/emulation/qemu-aarch64/Kconfig b/src/mainboard/emulation/qemu-aarch64/Kconfig index 7d8d7b2..ebdbf16 100644 --- a/src/mainboard/emulation/qemu-aarch64/Kconfig +++ b/src/mainboard/emulation/qemu-aarch64/Kconfig @@ -46,6 +46,6 @@
config DRAM_SIZE_MB int - default 1024 + default 261120 # The maximum dram size is 255GiB.
endif # BOARD_EMULATION_QEMU_AARCH64
Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35024 )
Change subject: mainboard/emulation/qemu-aarch64: Update DRAM_SIZE_MB ......................................................................
Patch Set 1:
This CL updates DRAM_SIZR_MB for QEMU/AArch64 to probe the maximum memory range. Could you review this CL?
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35024 )
Change subject: mainboard/emulation/qemu-aarch64: Update DRAM_SIZE_MB ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35024/1/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-aarch64/Kconfig:
https://review.coreboot.org/c/coreboot/+/35024/1/src/mainboard/emulation/qem... PS1, Line 47: DRAM_SIZE_MB What happens if we don't set this?
Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35024 )
Change subject: mainboard/emulation/qemu-aarch64: Update DRAM_SIZE_MB ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35024/1/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-aarch64/Kconfig:
https://review.coreboot.org/c/coreboot/+/35024/1/src/mainboard/emulation/qem... PS1, Line 47: DRAM_SIZE_MB
What happens if we don't set this?
If we don't set this, we would get less address size than its actual size.
probe_ramsize() is called with the start address of DRAM as a first argument and CONFIG_DRAM_SIZE_MB as a second argument. It tries to find the real end of DRAM in the range between them.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35024 )
Change subject: mainboard/emulation/qemu-aarch64: Update DRAM_SIZE_MB ......................................................................
mainboard/emulation/qemu-aarch64: Update DRAM_SIZE_MB
DRAM_SIZE_MB should be the maximum size (255GiB / -m 261120M) that’s possible with QEMU on AArch64 virt because it tries to search the DRAM_SIZE_MB range to find the true memory size.
Signed-off-by: Asami Doi d0iasm.pub@gmail.com Change-Id: Id479c0b18d1e1adceecdcca13e36119b95617e6d Reviewed-on: https://review.coreboot.org/c/coreboot/+/35024 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M Documentation/mainboard/emulation/qemu-aarch64.md M src/mainboard/emulation/qemu-aarch64/Kconfig 2 files changed, 4 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/Documentation/mainboard/emulation/qemu-aarch64.md b/Documentation/mainboard/emulation/qemu-aarch64.md index ee4c9e7..4df36a9 100644 --- a/Documentation/mainboard/emulation/qemu-aarch64.md +++ b/Documentation/mainboard/emulation/qemu-aarch64.md @@ -7,7 +7,7 @@ ```bash qemu-system-aarch64 -bios ./build/coreboot.rom \ -M virt,secure=on,virtualization=on -cpu cortex-a53 \ - -nographic -m 8912M + -nographic -m 8192M ```
- The default CPU in QEMU for AArch64 is a cortex-a15 which is 32-bit @@ -17,6 +17,7 @@ via `-machine secure=on,virtualization=on`. - You need to specify the size of memory more than 544 MiB because 512 MiB is reserved for the kernel. +- The maximum size of memory is 255GiB (-m 261120).
## Building coreboot with an arbitrary FIT payload There are 3 steps to make coreboot.rom for QEMU/AArch64. If you select @@ -30,7 +31,7 @@ ``` $ qemu-system-aarch64 \ -M virt,dumpdtb=virt.dtb,secure=on,virtualization=on \ - -cpu cortex-a53 -nographic -m 2048M + -cpu cortex-a53 -nographic -m 8192M ```
### 2. Build a FIT image with a DTB diff --git a/src/mainboard/emulation/qemu-aarch64/Kconfig b/src/mainboard/emulation/qemu-aarch64/Kconfig index 7d8d7b2..ebdbf16 100644 --- a/src/mainboard/emulation/qemu-aarch64/Kconfig +++ b/src/mainboard/emulation/qemu-aarch64/Kconfig @@ -46,6 +46,6 @@
config DRAM_SIZE_MB int - default 1024 + default 261120 # The maximum dram size is 255GiB.
endif # BOARD_EMULATION_QEMU_AARCH64
-
Asami Doi (Code Review) -
Patrick Georgi (Code Review)
-
Raul Rangel (Code Review)