Attention is currently required from: Felix Held, Martin Roth, Paul Menzel.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78221?usp=email )
Change subject: soc/amd/genoa: Add SMI support
......................................................................
Patch Set 8:
(3 comments)
File src/soc/amd/genoa/include/soc/smi.h:
https://review.coreboot.org/c/coreboot/+/78221/comment/cbfb1873_3470f11c :
PS7, Line 9: 59
i'd say that this should be 64; the highest sci map is scimap_63 in FCH::SMI::SCIMAP15
Done
https://review.coreboot.org/c/coreboot/+/78221/comment/c4170dde_dbd4f276 :
PS7, Line 56:
one tab too many. […]
Done
https://review.coreboot.org/c/coreboot/+/78221/comment/dae29b40_a5612413 :
PS7, Line 84: SMITYPE_WLAN_BT_PME
SMITYPE_ESPI1_WAKE_PME
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78221?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I491f4075cef8976e4b0762752c9e2e3c2ef886d5
Gerrit-Change-Number: 78221
Gerrit-PatchSet: 8
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 10 Oct 2023 13:14:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment