Attention is currently required from: Bora Guvendik, Anil Kumar K, Maulik V Vaghela, Rizwan Qureshi, Sugnan Prabhu S, Subrata Banik, Bernardo Perez Priego, Ronak Kanabar.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55526 )
Change subject: mb/intel/adlrvp: Remove ASL code and enable dynamic SSDT creation for camera ACPI
......................................................................
Patch Set 16:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55526/comment/21014045_eeb2cf17
PS15, Line 9: This change updates device tree to enable SSDT generation for world facing
Please reduce number of characters in one line.
Done
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55526/comment/de4daf01_677e7475
PS8, Line 307: ,
missing space after comma
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55526
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08834bbcf80dc46737de07f69a2402ed6bf93d4f
Gerrit-Change-Number: 55526
Gerrit-PatchSet: 16
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Fri, 02 Jul 2021 10:35:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment