Change in coreboot[master]: ec/google/chromec: Default EC_GOOGLE_CHROMEEC_LPC to disabled
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35154 )
Change subject: ec/google/chromec: Default EC_GOOGLE_CHROMEEC_LPC to disabled ......................................................................
ec/google/chromec: Default EC_GOOGLE_CHROMEEC_LPC to disabled
Don't set a default bus type for the Chrome EC on x86. The platform must select the bus, typically LPC or ESPI.
BUG=b:140055300 TEST=Build tested only
Change-Id: I736cb9e43292a1b228cd083ca81a8e5db383e878 Signed-off-by: Martin Roth martinroth@google.com --- M src/ec/google/chromeec/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/35154/1
diff --git a/src/ec/google/chromeec/Kconfig b/src/ec/google/chromeec/Kconfig index 2242653..2eb3b95 100644 --- a/src/ec/google/chromeec/Kconfig +++ b/src/ec/google/chromeec/Kconfig @@ -60,7 +60,7 @@
config EC_GOOGLE_CHROMEEC_LPC depends on EC_GOOGLE_CHROMEEC && ARCH_X86 # Needs Plug-and-play. - def_bool y + def_bool n help Google Chrome EC via LPC bus.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35154 )
Change subject: ec/google/chromec: Default EC_GOOGLE_CHROMEEC_LPC to disabled ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35154 )
Change subject: ec/google/chromec: Default EC_GOOGLE_CHROMEEC_LPC to disabled ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35154 )
Change subject: ec/google/chromec: Default EC_GOOGLE_CHROMEEC_LPC to disabled ......................................................................
ec/google/chromec: Default EC_GOOGLE_CHROMEEC_LPC to disabled
Don't set a default bus type for the Chrome EC on x86. The platform must select the bus, typically LPC or ESPI.
BUG=b:140055300 TEST=Build tested only
Change-Id: I736cb9e43292a1b228cd083ca81a8e5db383e878 Signed-off-by: Martin Roth martinroth@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35154 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/ec/google/chromeec/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/ec/google/chromeec/Kconfig b/src/ec/google/chromeec/Kconfig index 2242653..2eb3b95 100644 --- a/src/ec/google/chromeec/Kconfig +++ b/src/ec/google/chromeec/Kconfig @@ -60,7 +60,7 @@
config EC_GOOGLE_CHROMEEC_LPC depends on EC_GOOGLE_CHROMEEC && ARCH_X86 # Needs Plug-and-play. - def_bool y + def_bool n help Google Chrome EC via LPC bus.
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)