Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35780 )
Change subject: cpu/intel/: Fix regression with smmrelocate ......................................................................
cpu/intel/: Fix regression with smmrelocate
Fix regression with commit d53fd70 intel/smm/gen1: Use smm_subregion().
The bitmask on SMRR register parameter was inverted for selected models.
Change-Id: Ia572ca3bdd4da371985691b5d249f998382fbe48 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/intel/smm/gen1/smmrelocate.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/35780/1
diff --git a/src/cpu/intel/smm/gen1/smmrelocate.c b/src/cpu/intel/smm/gen1/smmrelocate.c index 4ecd7db..3eb869a 100644 --- a/src/cpu/intel/smm/gen1/smmrelocate.c +++ b/src/cpu/intel/smm/gen1/smmrelocate.c @@ -121,7 +121,7 @@
/* On model_6fx and model_1067x bits [0:11] on smrr_base are reserved */ if (cpu_has_alternative_smrr()) - params->smrr_base.lo &= ~rmask; + params->smrr_base.lo &= rmask;
smm_subregion(SMM_SUBREGION_CHIPSET, ¶ms->ied_base, ¶ms->ied_size); }
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35780 )
Change subject: cpu/intel/: Fix regression with smmrelocate ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35780 )
Change subject: cpu/intel/: Fix regression with smmrelocate ......................................................................
Patch Set 1: Code-Review+2
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35780 )
Change subject: cpu/intel/: Fix regression with smmrelocate ......................................................................
Patch Set 1: Code-Review+1
Great! The regression gets fixed with this.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35780 )
Change subject: cpu/intel/: Fix regression with smmrelocate ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35780 )
Change subject: cpu/intel/: Fix regression with smmrelocate ......................................................................
cpu/intel/: Fix regression with smmrelocate
Fix regression with commit d53fd70 intel/smm/gen1: Use smm_subregion().
The bitmask on SMRR register parameter was inverted for selected models.
Change-Id: Ia572ca3bdd4da371985691b5d249f998382fbe48 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35780 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Bill XIE persmule@hardenedlinux.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/cpu/intel/smm/gen1/smmrelocate.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Nico Huber: Looks good to me, approved Arthur Heymans: Looks good to me, approved Bill XIE: Looks good to me, but someone else must approve
diff --git a/src/cpu/intel/smm/gen1/smmrelocate.c b/src/cpu/intel/smm/gen1/smmrelocate.c index 4ecd7db..3eb869a 100644 --- a/src/cpu/intel/smm/gen1/smmrelocate.c +++ b/src/cpu/intel/smm/gen1/smmrelocate.c @@ -121,7 +121,7 @@
/* On model_6fx and model_1067x bits [0:11] on smrr_base are reserved */ if (cpu_has_alternative_smrr()) - params->smrr_base.lo &= ~rmask; + params->smrr_base.lo &= rmask;
smm_subregion(SMM_SUBREGION_CHIPSET, ¶ms->ied_base, ¶ms->ied_size); }