Kyösti Mälkki has uploaded this change for review.

cpu/intel/: Fix regression with smmrelocate

Fix regression with commit d53fd70 intel/smm/gen1: Use smm_subregion().

The bitmask on SMRR register parameter was inverted for
selected models.

Change-Id: Ia572ca3bdd4da371985691b5d249f998382fbe48
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
---
M src/cpu/intel/smm/gen1/smmrelocate.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/35780/1

diff --git a/src/cpu/intel/smm/gen1/smmrelocate.c b/src/cpu/intel/smm/gen1/smmrelocate.c
index 4ecd7db..3eb869a 100644
--- a/src/cpu/intel/smm/gen1/smmrelocate.c
+++ b/src/cpu/intel/smm/gen1/smmrelocate.c
@@ -121,7 +121,7 @@
 
 	/* On model_6fx and model_1067x bits [0:11] on smrr_base are reserved */
 	if (cpu_has_alternative_smrr())
-		params->smrr_base.lo &= ~rmask;
+		params->smrr_base.lo &= rmask;
 
 	smm_subregion(SMM_SUBREGION_CHIPSET, &params->ied_base, &params->ied_size);
 }

To view, visit change 35780. To unsubscribe, or for help writing mail filters, visit settings.