Change in coreboot[master]: mb/[google/intel]/*: Specify Chrome EC bus - LPC or ESPI

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35153 )

Change subject: mb/[google/intel]/*: Specify Chrome EC  bus - LPC or ESPI
......................................................................

mb/[google/intel]/*: Specify Chrome EC  bus - LPC or ESPI

Previously all boards using eSPI for the Chrome EC just called it
LPC as the code for the chrome EC is the same between the two
busses.

I'm adding a new Kconfig symbol to specify eSPI, so switch the
boards that actually use eSPI to that symbol and add the LPC
symbol to all the others.

The EC_GOOGLE_CHROMEEC_LPC symbol will no longer default
to enabled for x86 platforms, so one symbol or the other needs to be
specified for each platform.

BUG=b:140055300
TEST=Build tested only.

Change-Id: Icf242ca2b7d8b1470feda4e44b47a2cdc20680f2
Signed-off-by: Martin Roth 
---
M src/mainboard/google/auron/Kconfig
M src/mainboard/google/cyan/Kconfig
M src/mainboard/google/dragonegg/Kconfig
M src/mainboard/google/eve/Kconfig
M src/mainboard/google/glados/Kconfig
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/link/Kconfig
M src/mainboard/google/octopus/Kconfig
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/rambi/Kconfig
M src/mainboard/google/slippy/Kconfig
M src/mainboard/intel/glkrvp/Kconfig
M src/mainboard/intel/strago/Kconfig
13 files changed, 13 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/35153/1

diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig
index 69b086f..91abc6f 100644
--- a/src/mainboard/google/auron/Kconfig
+++ b/src/mainboard/google/auron/Kconfig
@@ -4,6 +4,7 @@
    select SOC_INTEL_BROADWELL
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
+	select EC_GOOGLE_CHROMEEC_LPC
    select HAVE_ACPI_TABLES
    select HAVE_OPTION_TABLE
    select HAVE_ACPI_RESUME
diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig
index bf0cd09..1929723 100644
--- a/src/mainboard/google/cyan/Kconfig
+++ b/src/mainboard/google/cyan/Kconfig
@@ -3,6 +3,7 @@
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_BOARDID
+	select EC_GOOGLE_CHROMEEC_LPC
    select EC_GOOGLE_CHROMEEC_MEC
    select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
    select ENABLE_BUILTIN_COM1
diff --git a/src/mainboard/google/dragonegg/Kconfig b/src/mainboard/google/dragonegg/Kconfig
index 39228f4..854330c 100644
--- a/src/mainboard/google/dragonegg/Kconfig
+++ b/src/mainboard/google/dragonegg/Kconfig
@@ -5,7 +5,7 @@
    select DRIVERS_I2C_HID
    select DRIVERS_SPI_ACPI
    select EC_GOOGLE_CHROMEEC
-	select EC_GOOGLE_CHROMEEC_LPC
+	select EC_GOOGLE_CHROMEEC_ESPI
    select HAVE_ACPI_RESUME
    select HAVE_ACPI_TABLES
    select INTEL_LPSS_UART_FOR_CONSOLE
diff --git a/src/mainboard/google/eve/Kconfig b/src/mainboard/google/eve/Kconfig
index 022493c..6f38436 100644
--- a/src/mainboard/google/eve/Kconfig
+++ b/src/mainboard/google/eve/Kconfig
@@ -11,7 +11,7 @@
    select DRIVERS_USB_ACPI
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_BOARDID
-	select EC_GOOGLE_CHROMEEC_LPC
+	select EC_GOOGLE_CHROMEEC_ESPI
    select HAVE_ACPI_RESUME
    select HAVE_ACPI_TABLES
    select INTEL_GMA_HAVE_VBT
diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig
index b75b726..f571dba 100644
--- a/src/mainboard/google/glados/Kconfig
+++ b/src/mainboard/google/glados/Kconfig
@@ -6,7 +6,7 @@
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
    select EC_GOOGLE_CHROMEEC_BOARDID
-	select EC_GOOGLE_CHROMEEC_LPC
+	select EC_GOOGLE_CHROMEEC_ESPI
    select EC_GOOGLE_CHROMEEC_MEC
    select EC_GOOGLE_CHROMEEC_PD
    select HAVE_ACPI_RESUME
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 5c7c267..72590c4 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -11,7 +11,7 @@
    select DRIVERS_USB_ACPI
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_BOARDID
-	select EC_GOOGLE_CHROMEEC_LPC
+	select EC_GOOGLE_CHROMEEC_ESPI
    select GOOGLE_SMBIOS_MAINBOARD_VERSION
    select HAVE_ACPI_RESUME
    select HAVE_ACPI_TABLES
diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig
index 6d62f64..a785eee 100644
--- a/src/mainboard/google/link/Kconfig
+++ b/src/mainboard/google/link/Kconfig
@@ -7,6 +7,7 @@
    select SOUTHBRIDGE_INTEL_C216
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
+	select EC_GOOGLE_CHROMEEC_LPC
    select HAVE_ACPI_TABLES
    select HAVE_OPTION_TABLE
    select HAVE_ACPI_RESUME
diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig
index 8ca9251..6abf68d 100644
--- a/src/mainboard/google/octopus/Kconfig
+++ b/src/mainboard/google/octopus/Kconfig
@@ -12,7 +12,7 @@
    select DRIVERS_USB_ACPI
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_BOARDID
-	select EC_GOOGLE_CHROMEEC_LPC
+	select EC_GOOGLE_CHROMEEC_ESPI
    select HAVE_ACPI_RESUME
    select HAVE_ACPI_TABLES
    select INTEL_LPSS_UART_FOR_CONSOLE
diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index fda8c9e..6970221 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -7,7 +7,7 @@
    select DRIVERS_I2C_HID
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_BOARDID
-	select EC_GOOGLE_CHROMEEC_LPC
+	select EC_GOOGLE_CHROMEEC_ESPI
    select HAVE_ACPI_RESUME
    select HAVE_ACPI_TABLES
    select INTEL_GMA_HAVE_VBT if BOARD_GOOGLE_NAMI
diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig
index 56d44bc..e5eb509 100644
--- a/src/mainboard/google/rambi/Kconfig
+++ b/src/mainboard/google/rambi/Kconfig
@@ -3,6 +3,7 @@
    def_bool n
    select SOC_INTEL_BAYTRAIL
    select EC_GOOGLE_CHROMEEC
+	select EC_GOOGLE_CHROMEEC_LPC
    select ENABLE_BUILTIN_COM1
    select BOARD_ROMSIZE_KB_8192
    select HAVE_ACPI_TABLES
diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig
index 35fced0..0bd6ff5 100644
--- a/src/mainboard/google/slippy/Kconfig
+++ b/src/mainboard/google/slippy/Kconfig
@@ -7,6 +7,7 @@
    select INTEL_LYNXPOINT_LP
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
+	select EC_GOOGLE_CHROMEEC_LPC
    select HAVE_ACPI_TABLES
    select HAVE_OPTION_TABLE
    select HAVE_ACPI_RESUME
diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig
index 920b446..74679a4b 100644
--- a/src/mainboard/intel/glkrvp/Kconfig
+++ b/src/mainboard/intel/glkrvp/Kconfig
@@ -30,7 +30,7 @@
 config GLK_CHROME_EC
    bool "Chrome EC"
    select EC_GOOGLE_CHROMEEC
-	select EC_GOOGLE_CHROMEEC_LPC
+	select EC_GOOGLE_CHROMEEC_ESPI

config GLK_INTEL_EC
    bool "Intel EC"
diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig
index da04d78..6f610a4 100644
--- a/src/mainboard/intel/strago/Kconfig
+++ b/src/mainboard/intel/strago/Kconfig
@@ -5,6 +5,7 @@
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_BOARDID
+	select EC_GOOGLE_CHROMEEC_LPC
    select EC_GOOGLE_CHROMEEC_MEC
    select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
    select ENABLE_BUILTIN_COM1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35153 )

Change subject: mb/[google/intel]/*: Specify Chrome EC  bus - LPC or ESPI
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35153/1/src/mainboard/google/glados... 
File src/mainboard/google/glados/Kconfig:

https://review.coreboot.org/c/coreboot/+/35153/1/src/mainboard/google/glados... 
PS1, Line 9: ESPI
Glados actually used LPC.

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35153 )

Change subject: mb/[google/intel]/*: Specify Chrome EC  bus - LPC or ESPI
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35153/1/src/mainboard/google/glados... 
File src/mainboard/google/glados/Kconfig:

https://review.coreboot.org/c/coreboot/+/35153/1/src/mainboard/google/glados... 
PS1, Line 9: ESPI
glados is lpc

[Martin Roth (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35153

to look at the new patch set (#2).

Change subject: mb/[google/intel]/*: Specify Chrome EC  bus - LPC or ESPI
......................................................................

mb/[google/intel]/*: Specify Chrome EC  bus - LPC or ESPI

Previously all boards using eSPI for the Chrome EC just called it
LPC as the code for the chrome EC is the same between the two
busses.

I'm adding a new Kconfig symbol to specify eSPI, so switch the
boards that actually use eSPI to that symbol and add the LPC
symbol to all the others.

The EC_GOOGLE_CHROMEEC_LPC symbol will no longer default
to enabled for x86 platforms, so one symbol or the other needs to be
specified for each platform.

BUG=b:140055300
TEST=Build tested only.

Change-Id: Icf242ca2b7d8b1470feda4e44b47a2cdc20680f2
Signed-off-by: Martin Roth 
---
M src/mainboard/google/auron/Kconfig
M src/mainboard/google/cyan/Kconfig
M src/mainboard/google/dragonegg/Kconfig
M src/mainboard/google/eve/Kconfig
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/link/Kconfig
M src/mainboard/google/octopus/Kconfig
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/rambi/Kconfig
M src/mainboard/google/slippy/Kconfig
M src/mainboard/intel/glkrvp/Kconfig
M src/mainboard/intel/strago/Kconfig
12 files changed, 12 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/35153/2

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35153 )

Change subject: mb/[google/intel]/*: Specify Chrome EC  bus - LPC or ESPI
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35153/1/src/mainboard/google/glados... 
File src/mainboard/google/glados/Kconfig:

https://review.coreboot.org/c/coreboot/+/35153/1/src/mainboard/google/glados... 
PS1, Line 9: ESPI
> Glados actually used LPC.

thanks.  Fixed.

https://review.coreboot.org/c/coreboot/+/35153/1/src/mainboard/google/glados... 
PS1, Line 9: ESPI
> glados is lpc

Thanks.  Fixed.

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35153 )

Change subject: mb/[google/intel]/*: Specify Chrome EC  bus - LPC or ESPI
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35153 )

Change subject: mb/[google/intel]/*: Specify Chrome EC  bus - LPC or ESPI
......................................................................

mb/[google/intel]/*: Specify Chrome EC  bus - LPC or ESPI

Previously all boards using eSPI for the Chrome EC just called it
LPC as the code for the chrome EC is the same between the two
busses.

I'm adding a new Kconfig symbol to specify eSPI, so switch the
boards that actually use eSPI to that symbol and add the LPC
symbol to all the others.

The EC_GOOGLE_CHROMEEC_LPC symbol will no longer default
to enabled for x86 platforms, so one symbol or the other needs to be
specified for each platform.

BUG=b:140055300
TEST=Build tested only.

Change-Id: Icf242ca2b7d8b1470feda4e44b47a2cdc20680f2
Signed-off-by: Martin Roth 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35153
Tested-by: build bot (Jenkins) 
Reviewed-by: Aaron Durbin 
---
M src/mainboard/google/auron/Kconfig
M src/mainboard/google/cyan/Kconfig
M src/mainboard/google/dragonegg/Kconfig
M src/mainboard/google/eve/Kconfig
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/link/Kconfig
M src/mainboard/google/octopus/Kconfig
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/rambi/Kconfig
M src/mainboard/google/slippy/Kconfig
M src/mainboard/intel/glkrvp/Kconfig
M src/mainboard/intel/strago/Kconfig
12 files changed, 12 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved

diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig
index 171418e..13348a3 100644
--- a/src/mainboard/google/auron/Kconfig
+++ b/src/mainboard/google/auron/Kconfig
@@ -4,6 +4,7 @@
    select SOC_INTEL_BROADWELL
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
+	select EC_GOOGLE_CHROMEEC_LPC
    select HAVE_ACPI_TABLES
    select HAVE_OPTION_TABLE
    select HAVE_ACPI_RESUME
diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig
index 6f830b2..647d4e9 100644
--- a/src/mainboard/google/cyan/Kconfig
+++ b/src/mainboard/google/cyan/Kconfig
@@ -3,6 +3,7 @@
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_BOARDID
+	select EC_GOOGLE_CHROMEEC_LPC
    select EC_GOOGLE_CHROMEEC_MEC
    select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
    select ENABLE_BUILTIN_COM1
diff --git a/src/mainboard/google/dragonegg/Kconfig b/src/mainboard/google/dragonegg/Kconfig
index dc6146c..1891cbe 100644
--- a/src/mainboard/google/dragonegg/Kconfig
+++ b/src/mainboard/google/dragonegg/Kconfig
@@ -5,7 +5,7 @@
    select DRIVERS_I2C_HID
    select DRIVERS_SPI_ACPI
    select EC_GOOGLE_CHROMEEC
-	select EC_GOOGLE_CHROMEEC_LPC
+	select EC_GOOGLE_CHROMEEC_ESPI
    select HAVE_ACPI_RESUME
    select HAVE_ACPI_TABLES
    select INTEL_LPSS_UART_FOR_CONSOLE
diff --git a/src/mainboard/google/eve/Kconfig b/src/mainboard/google/eve/Kconfig
index e646f23..c768ecc 100644
--- a/src/mainboard/google/eve/Kconfig
+++ b/src/mainboard/google/eve/Kconfig
@@ -11,7 +11,7 @@
    select DRIVERS_USB_ACPI
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_BOARDID
-	select EC_GOOGLE_CHROMEEC_LPC
+	select EC_GOOGLE_CHROMEEC_ESPI
    select HAVE_ACPI_RESUME
    select HAVE_ACPI_TABLES
    select INTEL_GMA_HAVE_VBT
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig
index 8bb0207..004cc28 100644
--- a/src/mainboard/google/hatch/Kconfig
+++ b/src/mainboard/google/hatch/Kconfig
@@ -11,7 +11,7 @@
    select DRIVERS_USB_ACPI
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_BOARDID
-	select EC_GOOGLE_CHROMEEC_LPC
+	select EC_GOOGLE_CHROMEEC_ESPI
    select GOOGLE_SMBIOS_MAINBOARD_VERSION
    select HAVE_ACPI_RESUME
    select HAVE_ACPI_TABLES
diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig
index b742190..12c5ffe 100644
--- a/src/mainboard/google/link/Kconfig
+++ b/src/mainboard/google/link/Kconfig
@@ -7,6 +7,7 @@
    select SOUTHBRIDGE_INTEL_C216
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
+	select EC_GOOGLE_CHROMEEC_LPC
    select HAVE_ACPI_TABLES
    select HAVE_OPTION_TABLE
    select HAVE_ACPI_RESUME
diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig
index 8120418..c13d7f8 100644
--- a/src/mainboard/google/octopus/Kconfig
+++ b/src/mainboard/google/octopus/Kconfig
@@ -12,7 +12,7 @@
    select DRIVERS_USB_ACPI
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_BOARDID
-	select EC_GOOGLE_CHROMEEC_LPC
+	select EC_GOOGLE_CHROMEEC_ESPI
    select HAVE_ACPI_RESUME
    select HAVE_ACPI_TABLES
    select INTEL_LPSS_UART_FOR_CONSOLE
diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index 91de9a8..07e3990 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -7,7 +7,7 @@
    select DRIVERS_I2C_HID
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_BOARDID
-	select EC_GOOGLE_CHROMEEC_LPC
+	select EC_GOOGLE_CHROMEEC_ESPI
    select HAVE_ACPI_RESUME
    select HAVE_ACPI_TABLES
    select INTEL_GMA_HAVE_VBT if BOARD_GOOGLE_NAMI
diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig
index 63e0d56..83bcc1a 100644
--- a/src/mainboard/google/rambi/Kconfig
+++ b/src/mainboard/google/rambi/Kconfig
@@ -3,6 +3,7 @@
    def_bool n
    select SOC_INTEL_BAYTRAIL
    select EC_GOOGLE_CHROMEEC
+	select EC_GOOGLE_CHROMEEC_LPC
    select ENABLE_BUILTIN_COM1
    select BOARD_ROMSIZE_KB_8192
    select HAVE_ACPI_TABLES
diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig
index 68b92bb..13dbe19 100644
--- a/src/mainboard/google/slippy/Kconfig
+++ b/src/mainboard/google/slippy/Kconfig
@@ -7,6 +7,7 @@
    select INTEL_LYNXPOINT_LP
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
+	select EC_GOOGLE_CHROMEEC_LPC
    select HAVE_ACPI_TABLES
    select HAVE_OPTION_TABLE
    select HAVE_ACPI_RESUME
diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig
index f10a9f0..3380762 100644
--- a/src/mainboard/intel/glkrvp/Kconfig
+++ b/src/mainboard/intel/glkrvp/Kconfig
@@ -30,7 +30,7 @@
 config GLK_CHROME_EC
    bool "Chrome EC"
    select EC_GOOGLE_CHROMEEC
-	select EC_GOOGLE_CHROMEEC_LPC
+	select EC_GOOGLE_CHROMEEC_ESPI

config GLK_INTEL_EC
    bool "Intel EC"
diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig
index 1f6a73d..5a49e8c 100644
--- a/src/mainboard/intel/strago/Kconfig
+++ b/src/mainboard/intel/strago/Kconfig
@@ -5,6 +5,7 @@
    select BOARD_ROMSIZE_KB_8192
    select EC_GOOGLE_CHROMEEC
    select EC_GOOGLE_CHROMEEC_BOARDID
+	select EC_GOOGLE_CHROMEEC_LPC
    select EC_GOOGLE_CHROMEEC_MEC
    select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
    select ENABLE_BUILTIN_COM1