Attention is currently required from: Arthur Heymans, Felix Held, Jérémy Compostella.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80330?usp=email )
Change subject: [WIP,UNTESTED] arch/x86/ioapic: always write IOAPIC ID in set_ioapic_id ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
haven't looked at all the details yet, but at least for the socs i work on the old behavior seems to […]
What I remember from the cleanup times is that today's IOAPICs probably don't care about their ID. Historically, an ID of 0 would have been wrong, because that was usually the BSP LAPIC (and they needed a unique ID on the APIC bus, which is gone). Not sure if anything still cares about the ID, though we have to put it into ACPI tables (I just saw). We read the ID from hardware for this, so we should also write it to hw I guess.