Attention is currently required from: Shelley Chen, Ravi kumar. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57449 )
Change subject: Herobrine: sc7280: Add support for audio ......................................................................
Patch Set 20:
(3 comments)
File src/mainboard/google/herobrine/chromeos.c:
https://review.coreboot.org/c/coreboot/+/57449/comment/0423e0de_b1be7e5e PS19, Line 16: gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP);
This belongs in CL:50581
Done
https://review.coreboot.org/c/coreboot/+/57449/comment/e1e20d37_891b6c7d PS19, Line 25: {GPIO_H1_AP_INT.addr, ACTIVE_HIGH, gpio_get(GPIO_H1_AP_INT), : "TPM interrupt"},
This belongs in CL:50581
Done
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/57449/comment/b04213e3_9886135a PS14, Line 45: gpio_configure(GPIO(106), GPIO106_FUNC_MI2S1_SCK, : GPIO_NO_PULL, GPIO_16MA, GPIO_OUTPUT); : : gpio_configure(GPIO(108), GPIO108_FUNC_MI2S1_WS, : GPIO_NO_PULL, GPIO_16MA, GPIO_OUTPUT); : : gpio_configure(GPIO(107), GPIO107_FUNC_MI2S1_DATA0, : GPIO_NO_PULL, GPIO_16MA, GPIO_OUTPUT); : }
Can we define these GPIO(..) values in board. […]
Done