mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23856 )
Change subject: tint: introduce the new tint build system with checksum verification ......................................................................
Patch Set 12: -Code-Review
Thank you, I will update my commit message a bit later, and already removed +1 (which I initially added only to display my confidence in this commit, since this +1 stands for "Looks good to me, but someone else must approve", but now I understand this is not needed)
Why not just extend the target below with the checksum verification?
download: test -d tint || { wget $(project_url); \ tar -xvf $(archive_name); \ rm $(archive_name); \ mv tint-0.04+nmu1 tint; }
buildgcc script has a lot of useful functions that I wanted to borrow, for example:
# Find all the required tools:
TAR=$(searchtool tar) || exit $? PATCH=$(searchtool patch) || exit $? MAKE=$(searchtool make) || exit $? SHA1SUM=$(searchtool sha1sum) #SHA512SUM=$(searchtool sha512sum) #MD5SUM=$(searchtool md5sum) CHECKSUM=$SHA1SUM LBZIP2=$(searchtool lbzip2 "" nofail) PIGZ=$(searchtool pigz "" nofail)
Here is how the generated tint .sh looks like - https://pastebin.com/jY8A5juD
I didn't want to simply copy these functions to avoid the need of keeping this copy up-to-date (or it becoming outdated). My "tint build system" will do it automatically by always generating this tint .sh script by itself, using the parts of fresh buildgcc script from a coreboot tree.