Change in ...coreboot[master]: This change add Raydium touchscreen device to Laser14 project.

[Hao He (Code Review)]

Hao He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31116

Change subject: This change add Raydium touchscreen device to Laser14 project.
......................................................................

This change add Raydium touchscreen device to Laser14 project.

BUG=b:121105424
TEST=emerge-octopus coreboot chromeos-bootimage
     reflash the coreboot to DUT,make sure the Raydium touchscreen can work.

Change-Id: I9ffb2a858f31a8b003086806de07f4079870cddf
Signed-off-by: hao.he 
---
M src/mainboard/google/octopus/variants/phaser/overridetree.cb
1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/31116/1

diff --git a/src/mainboard/google/octopus/variants/phaser/overridetree.cb b/src/mainboard/google/octopus/variants/phaser/overridetree.cb
index b131173..625c2a6 100644
--- a/src/mainboard/google/octopus/variants/phaser/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/phaser/overridetree.cb
@@ -159,6 +159,18 @@
    			register "hid_desc_reg_offset" = "0x20"
    			device i2c 20 on end
    		end
+                        chip drivers/i2c/generic
+                               register "hid" = ""RAYD0001""
+                               register "desc" = ""Raydium Touchscreen""
+                               register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)"
+                               register "probed" = "1"
+                               register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
+                               register "reset_delay_ms" = "1"
+                               register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)"
+                               register "enable_delay_ms" = "50"
+                               register "has_power_resource" = "1"
+                               device i2c 39 on end
+                       end
    	end	# - I2C 7
    end
 end

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: This change add Raydium touchscreen device to Laser14 project.
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31116/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31116/1//COMMIT_MSG@7 
PS1, Line 7: This change add Raydium touchscreen device to Laser14 project.
mb/google/octopus/var/phaser: Add Raydium touchscreen support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: This change add Raydium touchscreen device to Laser14 project.
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31116/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31116/1//COMMIT_MSG@9 
PS1, Line 9: BUG=b:121105424
BRANCH=octopus

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: This change add Raydium touchscreen device to Laser14 project.
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31116/1/src/mainboard/google/octopus/variant... 
File src/mainboard/google/octopus/variants/phaser/overridetree.cb:

https://review.coreboot.org/#/c/31116/1/src/mainboard/google/octopus/variant... 
PS1, Line 170: 50
Just confirming: Is this from the part datasheet?

Change in ...coreboot[master]: mb/google/octopus/var/phaser: Add Raydium touchscreen support

[Hao He (Code Review)]

Hello Aaron Durbin, Karthik Ramasubramanian, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31116

to look at the new patch set (#2).

Change subject: mb/google/octopus/var/phaser: Add Raydium touchscreen support
......................................................................

mb/google/octopus/var/phaser: Add Raydium touchscreen support

BUG=b:121105424
BRANCH=octopus
TEST=emerge-octopus coreboot chromeos-bootimage
     reflash the coreboot to DUT,make sure the Raydium touchscreen can work.

Change-Id: I9ffb2a858f31a8b003086806de07f4079870cddf
Signed-off-by: hao.he 
---
M src/mainboard/google/octopus/variants/phaser/overridetree.cb
1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/31116/2

Change in ...coreboot[master]: mb/google/octopus/var/phaser: Add Raydium touchscreen support

[Hao He (Code Review)]

Hao He has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: mb/google/octopus/var/phaser: Add Raydium touchscreen support
......................................................................

Patch Set 2:
> Patch Set 1:
>
> (1 comment)

Hi Furquan,
Regarding the value of enable_delay_ms, I refer to: octopus/variants/bobba/overridetree.cb

Change in ...coreboot[master]: mb/google/octopus/var/phaser: Add Raydium touchscreen support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: mb/google/octopus/var/phaser: Add Raydium touchscreen support
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 1:
> >
> > (1 comment)
>
> Hi Furquan,
> Regarding the value of enable_delay_ms, I refer to: octopus/variants/bobba/overridetree.cb

Oh okay.

Change in ...coreboot[master]: mb/google/octopus/var/phaser: Add Raydium touchscreen support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: mb/google/octopus/var/phaser: Add Raydium touchscreen support
......................................................................

Patch Set 2: Code-Review+2

Change in ...coreboot[master]: mb/google/octopus/var/phaser: Add Raydium touchscreen support

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: mb/google/octopus/var/phaser: Add Raydium touchscreen support
......................................................................

Patch Set 2:

(4 comments)

https://review.coreboot.org/#/c/31116/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31116/2//COMMIT_MSG@2 
PS2, Line 2: hao.he
Please use your name, and not the username. Maybe: Hao He

https://review.coreboot.org/#/c/31116/2//COMMIT_MSG@7 
PS2, Line 7: Add Raydium touchscreen support
Maybe:
> Hook up Raydium touchscreen

https://review.coreboot.org/#/c/31116/2//COMMIT_MSG@12 
PS2, Line 12: DUT,make
Please add a space after the comma.

https://review.coreboot.org/#/c/31116/2//COMMIT_MSG@15 
PS2, Line 15: hao.he
Ditto.

Change in ...coreboot[master]: mb/google/octopus/var/phaser: Add Raydium touchscreen support

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: mb/google/octopus/var/phaser: Add Raydium touchscreen support
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31116/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31116/2//COMMIT_MSG@8 
PS2, Line 8: 
Please mention, that a 50 ms delay is used, and how it affects boot time.

Change in ...coreboot[master]: mb/google/octopus/var/phaser: Add Raydium touchscreen support

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: mb/google/octopus/var/phaser: Add Raydium touchscreen support
......................................................................

Patch Set 2: Code-Review+2

Change in ...coreboot[master]: mb/google/octopus/var/phaser: Hook up Raydium touchscreen

[Hao He (Code Review)]

Hello Aaron Durbin, Karthik Ramasubramanian, Justin TerAvest, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31116

to look at the new patch set (#3).

Change subject: mb/google/octopus/var/phaser: Hook up Raydium touchscreen
......................................................................

mb/google/octopus/var/phaser: Hook up Raydium touchscreen

List Raydium touchscreen in the devicetree so that the correct ACPI device
are created.

BUG=b:121105424
BRANCH=octopus
TEST=emerge-octopus coreboot chromeos-bootimage
     reflash the coreboot to DUT, make sure the Raydium touchscreen can work.

Change-Id: I9ffb2a858f31a8b003086806de07f4079870cddf
Signed-off-by: Hao He 
---
M src/mainboard/google/octopus/variants/phaser/overridetree.cb
1 file changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/31116/3

Change in ...coreboot[master]: mb/google/octopus/var/phaser: Hook up Raydium touchscreen

[Hao He (Code Review)]

Hao He has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: mb/google/octopus/var/phaser: Hook up Raydium touchscreen
......................................................................

Patch Set 3:
> Patch Set 2:
>
> (1 comment)

Hi Paul,
The value of enable_delay_ms may have no effect, because I did not see the use of enable_gpio in the driver. This part of the control is controlled by the chip itself.

Change in ...coreboot[master]: mb/google/octopus/var/phaser: Hook up Raydium touchscreen

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: mb/google/octopus/var/phaser: Hook up Raydium touchscreen
......................................................................

Patch Set 3: Code-Review+2
> Patch Set 3:
> > Patch Set 2:
> >
> > (1 comment)
>
> Hi Paul,
> The value of enable_delay_ms may have no effect, because I did not see the use of enable_gpio in the driver. This part of the control is controlled by the chip itself.

To add more info, the delay is passed to the kernel and is not used by the I2C generic driver in coreboot. The touchscreen driver in kernel will use that delay when it asserts the enable GPIO. Hence no impact to the boot process.

Change in ...coreboot[master]: mb/google/octopus/var/phaser: Hook up Raydium touchscreen

[Hao He (Code Review)]

Hao He has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: mb/google/octopus/var/phaser: Hook up Raydium touchscreen
......................................................................

Patch Set 3: Code-Review+1

Hi Furquan,
Can you help merge this CL, thanks.

Change in ...coreboot[master]: mb/google/octopus/var/phaser: Hook up Raydium touchscreen

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: mb/google/octopus/var/phaser: Hook up Raydium touchscreen
......................................................................

Patch Set 3: Code-Review+1

Hao, thank you for the update, and explanations.

Hao, normally you do not score your own change-set.

Change in ...coreboot[master]: mb/google/octopus/var/phaser: Hook up Raydium touchscreen

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31116 )

Change subject: mb/google/octopus/var/phaser: Hook up Raydium touchscreen
......................................................................

mb/google/octopus/var/phaser: Hook up Raydium touchscreen

List Raydium touchscreen in the devicetree so that the correct ACPI device
are created.

BUG=b:121105424
BRANCH=octopus
TEST=emerge-octopus coreboot chromeos-bootimage
     reflash the coreboot to DUT, make sure the Raydium touchscreen can work.

Change-Id: I9ffb2a858f31a8b003086806de07f4079870cddf
Signed-off-by: Hao He 
Reviewed-on: https://review.coreboot.org/c/31116
Reviewed-by: Karthik Ramasubramanian 
Reviewed-by: Paul Menzel 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Justin TerAvest 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/octopus/variants/phaser/overridetree.cb
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Furquan Shaikh: Looks good to me, approved
  Justin TerAvest: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved
  Hao He: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/octopus/variants/phaser/overridetree.cb b/src/mainboard/google/octopus/variants/phaser/overridetree.cb
index b131173..625c2a6 100644
--- a/src/mainboard/google/octopus/variants/phaser/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/phaser/overridetree.cb
@@ -159,6 +159,18 @@
    			register "hid_desc_reg_offset" = "0x20"
    			device i2c 20 on end
    		end
+                        chip drivers/i2c/generic
+                               register "hid" = ""RAYD0001""
+                               register "desc" = ""Raydium Touchscreen""
+                               register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)"
+                               register "probed" = "1"
+                               register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)"
+                               register "reset_delay_ms" = "1"
+                               register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)"
+                               register "enable_delay_ms" = "50"
+                               register "has_power_resource" = "1"
+                               device i2c 39 on end
+                       end
    	end	# - I2C 7
    end
 end