Change in coreboot[master]: cpu/qemu-x86: Add x86_64 bootblock support

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35680 )

Change subject: cpu/qemu-x86: Add x86_64 bootblock support
......................................................................

Patch Set 7: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/35680/6/src/cpu/qemu-x86/cache_as_r... 
File src/cpu/qemu-x86/cache_as_ram_bootblock.S:

https://review.coreboot.org/c/coreboot/+/35680/6/src/cpu/qemu-x86/cache_as_r... 
PS6, Line 44: movd	%mm1, %rdi
            : 	shld	%rdi, 32
            : 	movd	%mm1, %rsi
            : 	or	%rsi, %rdi
            : 	movd	%mm2, %rsi
> Same as code below, move %mm0 - %mm2 into the register that are used as arguments for bootblock_c_entry_bist
> Check SysV ABI for x86_64.

Ah thx for the pointer. I was assuming all arguments were still pushed to the stack.

https://review.coreboot.org/c/coreboot/+/35680/6/util/pgtblgen/pgtblgen.c 
File util/pgtblgen/pgtblgen.c:

https://review.coreboot.org/c/coreboot/+/35680/6/util/pgtblgen/pgtblgen.c@42 
PS6, Line 42: #define RW   (1ULL << 1)
> Yes, you want to write to memory. If it's not set the memory is read only and you will get a page fault on write.

Also for RO media?