Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Johnny Lin, Jonathan Zhang, Lance Zhao, Lean Sheng Tan, Patrick Rudolph, Tim Chu, Tim Wawrzynczak.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81375?usp=email )
Change subject: soc/intel/xeon_sp: Add soc_acpigen_write_OSC_pci_domain
......................................................................
Patch Set 7:
(4 comments)
File src/acpi/acpigen_pci.c:
https://review.coreboot.org/c/coreboot/+/81375/comment/1fe90b07_e26b0e60 :
PS6, Line 217: soc_acpigen_OSC_handle_pcie_request
drop this line
Done
File src/acpi/acpigen_pci.c:
https://review.coreboot.org/c/coreboot/+/81375/comment/6fce6c25_8ce63d61 :
PS7, Line 175: acpigen_write_if_lequal_op_int
In between the Arg1 "revision check" and Arg2 "number of arguments" check is missing compared to the […]
Good catch! updated
https://review.coreboot.org/c/coreboot/+/81375/comment/a8b43155_fdd051d8 :
PS7, Line 177: LOCAL1_OP
Since RETE is always 0 here, Local1 is always 0. […]
Done
File src/include/acpi/acpigen_pci.h:
https://review.coreboot.org/c/coreboot/+/81375/comment/77860d09_49fbe8e0 :
PS7, Line 27: soc_acpigen_write_OSC_pci_domain
function prototype should start with `acpigen_` since this code reside in `src/acpi/`
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81375?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I711ce5350d718e47feb2912555108801ad7f918d
Gerrit-Change-Number: 81375
Gerrit-PatchSet: 7
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 25 Mar 2024 05:03:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment