Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47860 )
Change subject: soc/intel/tigerlake: Refactor TCSS port mux config ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/47860/1/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/47860/1/src/soc/intel/tigerlake/chi... PS1, Line 339: struct tcss_config { suggestion: A little bit of documentation about using IOM_AUX_ORI_BIAS_CTRL for the bias_control* fields
https://review.coreboot.org/c/coreboot/+/47860/1/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/47860/1/src/soc/intel/tigerlake/fsp... PS1, Line 139: params->TcssAuxOri |= IOM_TCSS_PORT_CTRL(i, nit: blank line after continue
-
Tim Wawrzynczak (Code Review)