Patch set updated for coreboot: b9fe93f resources: remove IORESOURCE_[UMA_FB|IGNORE_MTRR]

[Aaron Durbin]

Aaron Durbin ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2890

-gerrit

commit b9fe93fe03b73ecd737ac1d854e6f47c24350f13
Author: Aaron Durbin 
Date:   Fri Mar 22 22:09:46 2013 -0500

resources: remove IORESOURCE_[UMA_FB|IGNORE_MTRR]

The IORESOURCE_UMA_FB and IORESOURCE_IGNORE_MTRR attributes
    on a resource provided hints to the MTRR algorithm. The
    IORESOURCE_UMA_FB directed the MTRR algorithm to setup a uncacheable
    space for the resource. The IORESOURCE_IGNORE_MTRR directed
    the MTRR algorithm to ignore this resource as it was used reserving
    RAM space.

Now that the optimizing MTRR algorithm is in place there isn't a need
    for these flags. All IORESOURCE_IGNORE_MTRR users are handled by the
    MTRR code merging resources of the same cacheable type. The users
    of the IORESOURCE_UMA_FB will find that the default MTRR type
    calculation mean there isn't a need for this flag any more.

Change-Id: I4f62192edd9a700cb80fa7569caf49538f9b83b7
    Signed-off-by: Aaron Durbin 
---
 src/include/device/device.h   | 6 +++---
 src/include/device/resource.h | 2 --
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/include/device/device.h b/src/include/device/device.h
index b8dfbf5..44a9742 100644
--- a/src/include/device/device.h
+++ b/src/include/device/device.h
@@ -207,16 +207,16 @@ void fixed_mem_resource(device_t dev, unsigned long index,
    fixed_mem_resource(dev, idx, basek, sizek, IORESOURCE_CACHEABLE)

#define reserved_ram_resource(dev, idx, basek, sizek) \
-	fixed_mem_resource(dev, idx, basek, sizek, IORESOURCE_CACHEABLE | IORESOURCE_RESERVE | IORESOURCE_IGNORE_MTRR)
+	fixed_mem_resource(dev, idx, basek, sizek, IORESOURCE_CACHEABLE | IORESOURCE_RESERVE)

#define bad_ram_resource(dev, idx, basek, sizek) \
    reserved_ram_resource((dev), (idx), (basek), (sizek))

#define uma_resource(dev, idx, basek, sizek) \
-	fixed_mem_resource(dev, idx, basek, sizek, IORESOURCE_RESERVE | IORESOURCE_UMA_FB)
+	fixed_mem_resource(dev, idx, basek, sizek, IORESOURCE_RESERVE)

#define mmio_resource(dev, idx, basek, sizek) \
-	fixed_mem_resource(dev, idx, basek, sizek, IORESOURCE_RESERVE | IORESOURCE_IGNORE_MTRR)
+	fixed_mem_resource(dev, idx, basek, sizek, IORESOURCE_RESERVE)

void tolm_test(void *gp, struct device *dev, struct resource *new);
 u32 find_pci_tolm(struct bus *bus);
diff --git a/src/include/device/resource.h b/src/include/device/resource.h
index ea1bab5..6b66605 100644
--- a/src/include/device/resource.h
+++ b/src/include/device/resource.h
@@ -21,8 +21,6 @@
    					 * to the bus below.
    					 */
 #define IORESOURCE_BRIDGE	0x00080000	/* The IO resource has a bus below it. */
-#define IORESOURCE_UMA_FB	0x00100000	/* UMA framebuffer */
-#define IORESOURCE_IGNORE_MTRR	0x00200000	/* The resource does not affect MTRR setup. */

#define IORESOURCE_RESERVE	0x10000000	/* The resource needs to be reserved in the coreboot table */
 #define IORESOURCE_STORED	0x20000000	/* The IO resource assignment has been stored in the device */