Attention is currently required from: Raul Rangel, Julius Werner. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62506 )
Change subject: libpayload: cbmem_console: Drop loglevel markers from snapshot ......................................................................
Patch Set 1:
(1 comment)
File payloads/libpayload/drivers/cbmem_console.c:
https://review.coreboot.org/c/coreboot/+/62506/comment/dd57770b_ce15739a PS1, Line 120: /* Slight memory corruption may occur between reboots and give us a few : unprintable characters like '\0'. Replace them with '?' on output. */ : for (cursor = 0; cursor < size; cursor++) : if (!isprint(console_c[cursor]) && !isspace(console_c[cursor])) : console_c[cursor] = '?';
For that to take effect we just need to remove the code block here.
Correction. We still need to replace '\0' with '?' here. Otherwise the substring after '\0' would be discarded in payloads.