Attention is currently required from: Jason Glenesk, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50513 )
Change subject: soc/amd/common: add and use fch_enable_ioapic_decode
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/soc/amd/common/block/smbus/sm.c:
https://review.coreboot.org/c/coreboot/+/50513/comment/6c03203f_ee602274
PS2, Line 15: CONFIG_MAX_CPUS
Hrmm, this is concerning. We have a Kconfig for setting the IO_APIC ID: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50513
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife886451a6927965769282fc5644c2085abb9585
Gerrit-Change-Number: 50513
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 11 Feb 2021 20:35:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment