Attention is currently required from: Paul Menzel, Reagan.
Nico Huber has posted comments on this change by Reagan. ( https://review.coreboot.org/c/coreboot/+/82506?usp=email )
Change subject: mb/razer/blade_stealth_kbl: Add H3Q variant ......................................................................
Patch Set 6:
(3 comments)
Patchset:
PS6: Just one Kconfig nit and OC questions... looks quite good otherwise :)
File src/mainboard/razer/blade_stealth_kbl/Kconfig:
https://review.coreboot.org/c/coreboot/+/82506/comment/66f49e8c_f3f3ac80?usp... : PS6, Line 4: def_bool n Technically, a `def_bool n` isn't necessary. Only difference are not being able to override the default later and .config cosmetics: without a default it won't show up as not enabled. For a mainboard option, I'd prefer to remove it, i.e. just have `bool` here (other- wise it would be mentioned in every coreboot .config, no matter what board is selected).
File src/mainboard/razer/blade_stealth_kbl/variants/h3q/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/82506/comment/12d4efb0_6761bd74?usp... : PS6, Line 7: OC_SKIP No OC pin seems unlikely for a laptop's external ports. Was this confirmed? or is it simply unknown?