Attention is currently required from: Tarun Tuli, Subrata Banik.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70132 )
Change subject: soc/intel/meteorlake: Refactor `pmc_lockdown_cfg` function
......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
File src/soc/intel/meteorlake/lockdown.c:
https://review.coreboot.org/c/coreboot/+/70132/comment/63e8269b_83134dd6
PS1, Line 25: setbits32(pmcbase + GEN_PMCON_B, SMI_LOCK);
need to add the same from ADL […]
Ack. Thanks for the clarification.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70132
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3622748d8fecef69c60bb3fe9bfe68fc126764b7
Gerrit-Change-Number: 70132
Gerrit-PatchSet: 3
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Tue, 29 Nov 2022 17:03:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment