Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC
Add new ID for memory part H5ANAG6NDMR-XNC.
Command to generate files: go build gen_part_id.go local variant=vilboz ./gen_part_id ../../../src/mainboard/google/zork/spd ../../../src/mainboard/google/zork/variants/${variant}/spd/ ../../../src/mainboard/google/zork/variants/${variant}/spd/mem_parts_used.txt
BUG=b:165611994 TEST=none
Change-Id: Iaf613d54bf23b637e38917937ce3e78702b26a28 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- M src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc M src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/45682/1
diff --git a/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc b/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc index 8868a69..c7890d0 100644 --- a/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc @@ -9,3 +9,4 @@ SPD_SOURCES += ddr4-spd-1.hex # ID = 4(0b0100) Parts = MT40A512M16TB-062E:J SPD_SOURCES += ddr4-spd-7.hex # ID = 5(0b0101) Parts = K4AAG165WA-BCWE SPD_SOURCES += ddr4-spd-7.hex # ID = 6(0b0110) Parts = MT40A1G16KD-062E:E +SPD_SOURCES += ddr4-spd-2.hex # ID = 7(0b0111) Parts = H5ANAG6NDMR-XNC diff --git a/src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt index bfbe034..8afd956 100644 --- a/src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt +++ b/src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt @@ -4,3 +4,4 @@ MT40A512M16TB-062E:J 4 (0100) K4AAG165WA-BCWE 5 (0101) MT40A1G16KD-062E:E 6 (0110) +H5ANAG6NDMR-XNC 7 (0111) diff --git a/src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt index 08f4891..2b8d6df 100644 --- a/src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt +++ b/src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt @@ -12,3 +12,4 @@ MT40A512M16TB-062E:J, 4 K4AAG165WA-BCWE, 5 MT40A1G16KD-062E:E, 6 +H5ANAG6NDMR-XNC, 7
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45682/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45682/1//COMMIT_MSG@16 PS1, Line 16: BUG=b:165611994 Please fix the indent.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Tim Wawrzynczak, Rob Barnes, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45682
to look at the new patch set (#2).
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC
Add new ID for memory part H5ANAG6NDMR-XNC.
Command to generate files: go build gen_part_id.go local variant=vilboz ./gen_part_id ../../../src/mainboard/google/zork/spd ../../../src/mainboard/google/zork/variants/${variant}/spd/ ../../../src/mainboard/google/zork/variants/${variant}/spd/mem_parts_used.txt
BUG=b:165611994 TEST=none
Change-Id: Iaf613d54bf23b637e38917937ce3e78702b26a28 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- M src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc M src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/45682/2
Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45682/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45682/1//COMMIT_MSG@16 PS1, Line 16: BUG=b:165611994
Please fix the indent.
Done.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 2: Code-Review+2
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... PS2, Line 15: H5ANAG6NDMR-XNC, 7 Please do not include an index unless there are already boards with this id strapped.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... PS2, Line 15: H5ANAG6NDMR-XNC, 7
Please do not include an index unless there are already boards with this id strapped.
But there is plan for HW implemented. You mean after real boards comes out? Would it be too late? And this is connected with Makefile, generated by auto_gen tool.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... PS2, Line 15: H5ANAG6NDMR-XNC, 7
But there is plan for HW implemented. […]
If the id here is removed, an id will be assigned automatically by the tool. This is preferred since in many cases an existing id can be reused.
Is id 7 required for the planned hw, or can the planned hw be strapped to a different id?
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... PS2, Line 15: H5ANAG6NDMR-XNC, 7
If the id here is removed, an id will be assigned automatically by the tool. […]
You can leave you comment for HW in https://partnerissuetracker.corp.google.com/issues/165611994. We just follow the HW plan, thanks.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 2: -Code-Review
(1 comment)
Please rebase these changes on https://review.coreboot.org/c/coreboot/+/45647
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... PS2, Line 15: H5ANAG6NDMR-XNC, 7
You can leave you comment for HW in https://partnerissuetracker.corp.google.com/issues/165611994. […]
I checked and in this case there are no other existing compatible ids for this part, so removing the id here won't make a material difference. I'll also leave a comment on the bug for future reference.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... PS2, Line 15: H5ANAG6NDMR-XNC, 7
I checked and in this case there are no other existing compatible ids for this part, so removing the […]
Thanks. Done
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45682/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45682/1//COMMIT_MSG@16 PS1, Line 16: BUG=b:165611994
Done.
Done
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 3: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... PS2, Line 15: H5ANAG6NDMR-XNC, 7
Thanks. […]
If the ID hasn't been used on any build, we should drop the 7 and let the tool assign it. I understand that the tool would end up assigning the same ID in this case, but we should follow consistent process so that there is no confusion when adding memory parts in the future.
Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... PS2, Line 15: H5ANAG6NDMR-XNC, 7
If the ID hasn't been used on any build, we should drop the 7 and let the tool assign it. […]
Due to HW have planned to use the RAM ID table from https://partnerissuetracker.corp.google.com/issues/165611994#comment5 for EVT schematic gerber out. If we dropped the 7 and let the tool assign it, 0 will be assigned and this will not meet the RAM ID table in EVT schematic. In the future we will use the tool to assign an ID before putting the ID in the schematic. Thanks.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v... PS2, Line 15: H5ANAG6NDMR-XNC, 7
Due to HW have planned to use the RAM ID table from https://partnerissuetracker.corp.google. […]
SG. Thanks Amanda!
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC ......................................................................
mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC
Add new ID for memory part H5ANAG6NDMR-XNC.
Command to generate files: go build gen_part_id.go local variant=vilboz ./gen_part_id ../../../src/mainboard/google/zork/spd ../../../src/mainboard/google/zork/variants/${variant}/spd/ ../../../src/mainboard/google/zork/variants/${variant}/spd/mem_parts_used.txt
BUG=b:165611994 TEST=none
Change-Id: Iaf613d54bf23b637e38917937ce3e78702b26a28 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45682 Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc M src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved EricR Lai: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc b/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc index 8868a69..c7890d0 100644 --- a/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc @@ -9,3 +9,4 @@ SPD_SOURCES += ddr4-spd-1.hex # ID = 4(0b0100) Parts = MT40A512M16TB-062E:J SPD_SOURCES += ddr4-spd-7.hex # ID = 5(0b0101) Parts = K4AAG165WA-BCWE SPD_SOURCES += ddr4-spd-7.hex # ID = 6(0b0110) Parts = MT40A1G16KD-062E:E +SPD_SOURCES += ddr4-spd-2.hex # ID = 7(0b0111) Parts = H5ANAG6NDMR-XNC diff --git a/src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt index bfbe034..8afd956 100644 --- a/src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt +++ b/src/mainboard/google/zork/variants/vilboz/spd/dram_id.generated.txt @@ -4,3 +4,4 @@ MT40A512M16TB-062E:J 4 (0100) K4AAG165WA-BCWE 5 (0101) MT40A1G16KD-062E:E 6 (0110) +H5ANAG6NDMR-XNC 7 (0111) diff --git a/src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt index 08f4891..2b8d6df 100644 --- a/src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt +++ b/src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt @@ -12,3 +12,4 @@ MT40A512M16TB-062E:J, 4 K4AAG165WA-BCWE, 5 MT40A1G16KD-062E:E, 6 +H5ANAG6NDMR-XNC, 7
-
Amanda Hwang (Code Review) -
EricR Lai (Code Review)
-
Furquan Shaikh (Code Review)
-
Rob Barnes (Code Review)