Attention is currently required from: Sudheer Amrabadi, mturney mturney. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/qc_blobs/+/62292 )
Change subject: Add documentation for qclib interface table ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: Let's not duplicate the same file for each SoC... if the code implementing this is common, the documentation should also be common. Maybe we can factor this out into a toplevel docs/ directory in this repository.
File sc7280/boot/qclib-interface.md:
https://review.coreboot.org/c/qc_blobs/+/62292/comment/5ae859be_b2568519 PS1, Line 28:
Poor sentence structure, ... to available in user space, isn't good English. […]
The translation from mem_chip_info into Device Tree is specific to depthcharge, so it shouldn't be mentioned here. This should just say that QcLib exports a data structure in coreboot's generic mem_chip_info format which contains this information about the detected memory, and can be copied into CBMEM_ID_MEM_CHIP_INFO to make that information available to the payload and OS.
-
Julius Werner (Code Review)