Change in coreboot[master]: mb/siemens/mc_ehl: Move SPD data to variant directory - coreboot-gerrit

5 Jul 2021


      Attention is currently required from: Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56036 )
Change subject: mb/siemens/mc_ehl: Move SPD data to variant directory
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56036/comment/928279e0_3ceb2a21 
PS2, Line 8: LIB_SPD_DEPS := $(foreach f, $(SPD_SOURCES), \
           : 			src/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/spd/$(f).spd.hex)
...
I did this in order to be flexible with the spd file naming in the future. […]
You can leave it like that. It's fine for me.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56036
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38aa5e7514437bfcc61c38d64f0ba6f19350810d
Gerrit-Change-Number: 56036
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 05 Jul 2021 12:50:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer mario.scheithauer@siemens.com
Comment-In-Reply-To: Werner Zeh werner.zeh@siemens.com
Gerrit-MessageType: comment