Attention is currently required from: David Wu, Kapil Porwal, Morris Hsu, Nick Vaccaro, Subrata Banik.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80809?usp=email )
Change subject: mb/google/brya/var/dochi: Add wifi sar table
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/dochi/variant.c:
https://review.coreboot.org/c/coreboot/+/80809/comment/81699c62_bf7bea2d :
PS1, Line 3: #include <chip.h>
could you update a patch to reorder the header file?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80809?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaf90756eb318bef1ffcda9368a976c0ca209a100
Gerrit-Change-Number: 80809
Gerrit-PatchSet: 1
Gerrit-Owner: Morris Hsu
morris-hsu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Morris Hsu
morris-hsu@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sat, 02 Mar 2024 06:37:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment