Attention is currently required from: Christian Walter, Martin L Roth, Maximilian Brune, Stefan Reinauer.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78644?usp=email )
Change subject: payloads/LinuxBoot: Build the linux kernel with -j $(CPUS)
......................................................................
Patch Set 2:
(1 comment)
File payloads/external/LinuxBoot/targets/linux.mk:
https://review.coreboot.org/c/coreboot/+/78644/comment/727679cf_713d1afe :
PS1, Line 48: echo "$(MAKE) -j $(CPUS) -C $(kernel_dir) $(KERNEL_MAKE_FLAGS) vmlinux"
I CPUS is not set it would automatically use the maximum number of jobs. You should probably check if CPUS is set before using it.
It's always set by xcompile.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78644?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7af5aef4560b8d4dd840d9c578f8a2a4c387400
Gerrit-Change-Number: 78644
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Tue, 27 Feb 2024 09:08:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment