Attention is currently required from: Jonathan Zhang, Johnny Lin, Shuming Chu (Shuming), Arthur Heymans, Kyösti Mälkki, TangYiwei.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69222 )
Change subject: cpu/x86/topology: Add code to fill in topology on struct path
......................................................................
Patch Set 15:
(2 comments)
File src/cpu/x86/topology.c:
https://review.coreboot.org/c/coreboot/+/69222/comment/d52c4c48_e854c359
PS15, Line 36: >=
Not sure ">=" is correct here. I suppose it should be "<".
This looks wrong indeed.
https://review.coreboot.org/c/coreboot/+/69222/comment/355f4437_c9832327
PS15, Line 48: ==
Also here. It should be "!=".
This seems fine, it skips the SMT level
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69222
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2210eb9b663dd90941a64132aa7154440dc7e5a9
Gerrit-Change-Number: 69222
Gerrit-PatchSet: 15
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Sun, 01 Jan 2023 18:07:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-MessageType: comment